metamask-extension icon indicating copy to clipboard operation
metamask-extension copied to clipboard

feat: add consent checkbox to onboarding metametrics page

Open mirceanis opened this issue 3 months ago • 3 comments

Description

This adds a consent checkbox to the onboarding metametrics screen. In this draft, the checkbox isn't wired to anything yet.

Open in GitHub Codespaces

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/2526

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

before

After

after

Pre-merge author checklist

  • [X] I’ve followed MetaMask Coding Standards.
  • [X] I've completed the PR template to the best of my ability
  • [X] I’ve included tests if applicable
  • [ ] I’ve documented my code using JSDoc format if applicable
  • [ ] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

mirceanis avatar May 17 '24 10:05 mirceanis

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] avatar May 17 '24 10:05 github-actions[bot]

I have read the CLA Document and I hereby sign the CLA

mirceanis avatar May 17 '24 10:05 mirceanis

Builds ready [2322921]
Page Load Metrics (1714 ± 514 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint771931153014
domContentLoaded98520189
load64278717141071514
domInteractive98520189
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 186 Bytes (0.00%)
  • common: 184 Bytes (0.00%)

metamaskbot avatar May 17 '24 13:05 metamaskbot