MetaMask
refactor: removed the whats new modal for portfolio
Description
Removed the "What's new" notification modal for the Portfolio. This is being removed because it was requested.
Related issues
Fixes: 1150
Manual testing steps
- Download MM extension
- On a fresh install, scroll down to the "what's new" notification modal
- Check that the Portfolio notifications modal is no longer rendering
Screenshots/Recordings
Before
After
https://www.loom.com/share/451bc9aee9024097928a4ca7464e80e7
Pre-merge author checklist
- [X] I’ve followed MetaMask Coding Standards.
- [X] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using JSDoc format if applicable
- [ ] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
Pre-merge reviewer checklist
- [X] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
- [X] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 67.39%. Comparing base (
c897b49) to head (4cc261c).
:exclamation: Current head 4cc261c differs from pull request most recent head 1b9ca46
Please upload reports for the commit 1b9ca46 to get more accurate results.
Additional details and impacted files
@@ Coverage Diff @@
## develop #24566 +/- ##
===========================================
+ Coverage 67.37% 67.39% +0.02%
===========================================
Files 1289 1289
Lines 50221 50212 -9
Branches 13005 13008 +3
===========================================
+ Hits 33836 33840 +4
+ Misses 16385 16372 -13
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
![codecov[bot] avatar](https://avatars.githubusercontent.com/in/254?v=4 "Published by a pub.dev verified publisher"){kind=small}
Builds ready [4cc261c]
- builds: chrome, firefox
- builds (beta): chrome
- builds (flask): chrome, firefox
- builds (MMI): chrome, firefox
- builds (test): chrome, firefox
- builds (test-flask): chrome, firefox
- build viz: Build System
- mv3: Background Module Init Stats
- mv3: UI Init Stats
- mv3: Module Load Stats
- mv3: Bundle Size Stats
- mv2: E2e Actions Stats
- code coverage: Report
- storybook: Storybook
- typescript migration: Dashboard
- all artifacts
Page Load Metrics (648 ± 486 ms)
| Platform | Page | Metric | Min (ms) | Max (ms) | Average (ms) | StandardDeviation (ms) | MarginOfError (ms) |
|---|---|---|---|---|---|---|---|
| Chrome | Home | firstPaint | 68 | 131 | 86 | 18 | 9 |
| domContentLoaded | 10 | 48 | 16 | 11 | 5 | ||
| load | 55 | 2631 | 648 | 1012 | 486 | ||
| domInteractive | 9 | 48 | 16 | 11 | 5 |
Bundle size diffs [🚀 Bundle size reduced!]
- background: 0 Bytes (0.00%)
- ui: -200 Bytes (-0.00%)
- common: -1.09 KiB (-0.02%)
Builds ready [ef885ae]
- builds: chrome, firefox
- builds (beta): chrome
- builds (flask): chrome, firefox
- builds (MMI): chrome, firefox
- builds (test): chrome, firefox
- builds (test-flask): chrome, firefox
- build viz: Build System
- mv3: Background Module Init Stats
- mv3: UI Init Stats
- mv3: Module Load Stats
- mv3: Bundle Size Stats
- mv2: E2e Actions Stats
- code coverage: Report
- storybook: Storybook
- typescript migration: Dashboard
- all artifacts
Page Load Metrics (1130 ± 564 ms)
| Platform | Page | Metric | Min (ms) | Max (ms) | Average (ms) | StandardDeviation (ms) | MarginOfError (ms) |
|---|---|---|---|---|---|---|---|
| Chrome | Home | firstPaint | 78 | 171 | 108 | 30 | 14 |
| domContentLoaded | 11 | 28 | 16 | 5 | 3 | ||
| load | 65 | 2684 | 1130 | 1175 | 564 | ||
| domInteractive | 11 | 28 | 16 | 5 | 3 |
Bundle size diffs [🚀 Bundle size reduced!]
- background: 0 Bytes (0.00%)
- ui: -200 Bytes (-0.00%)
- common: -1.09 KiB (-0.02%)