metamask-extension icon indicating copy to clipboard operation
metamask-extension copied to clipboard

Published 20 hours ago • verified publisher icon MetaMask

feat: adds the new default settings view to onboarding

Open zone-live opened this issue 9 months ago • 2 comments

Description

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • [ ] I’ve followed MetaMask Coding Standards.
  • [ ] I've completed the PR template to the best of my ability
  • [ ] I’ve included tests if applicable
  • [ ] I’ve documented my code using JSDoc format if applicable
  • [ ] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

zone-live avatar May 16 '24 13:05 zone-live

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] avatar May 16 '24 13:05 github-actions[bot]

Builds ready [a81133f]
Page Load Metrics (1002 ± 551 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint6114092199
domContentLoaded9301463
load57256410021147551
domInteractive9301463
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 4.01 KiB (0.06%)
  • common: 647 Bytes (0.01%)

metamaskbot avatar May 20 '24 15:05 metamaskbot

Builds ready [cf34cc7]
Page Load Metrics (803 ± 539 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint60193953115
domContentLoaded96416136
load4828258031122539
domInteractive96416136
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 4.01 KiB (0.06%)
  • common: 647 Bytes (0.01%)

metamaskbot avatar May 21 '24 11:05 metamaskbot

Builds ready [eb245b7]
Page Load Metrics (102 ± 119 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint67997774
domContentLoaded812910
load401183102248119
domInteractive812910

metamaskbot avatar Jun 04 '24 14:06 metamaskbot

Codecov Report

Attention: Patch coverage is 77.77778% with 20 lines in your changes missing coverage. Please review.

Project coverage is 65.04%. Comparing base (8e48bee) to head (5becf27). Report is 8 commits behind head on develop.

Files Patch % Lines
...boarding-flow/privacy-settings/privacy-settings.js 70.69% 17 Missing :warning:
...ges/onboarding-flow/pin-extension/pin-extension.js 57.14% 3 Missing :warning:
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop   #24562      +/-   ##
===========================================
+ Coverage    65.02%   65.04%   +0.02%     
===========================================
  Files         1391     1391              
  Lines        55182    55232      +50     
  Branches     14499    14528      +29     
===========================================
+ Hits         35879    35922      +43     
- Misses       19303    19310       +7

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jun 04 '24 14:06 codecov[bot]

Builds ready [317f8e9]
Page Load Metrics (154 ± 186 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint7513298157
domContentLoaded9261442
load451843154388186
domInteractive9261442

metamaskbot avatar Jun 05 '24 11:06 metamaskbot

Overall it looks great! Design QA:

  1. When I click back button on the default settings page, it automatically ends the onboarding flow
  2. On "Assets" page, "Show incoming transactions" is not using the same text as other headers. Screenshot 2024-06-05 at 11 55 25 AM

Also, it will be great if we can:

  1. For "Your wallet is ready" screen, combine the sentences into 1 paragraph and highlight only "Learn more" (Sorry I might not have specified that earlier) Wallet is ready
  2. On default settings page, expand the touch area to be not just the title, but the entire cell Touch area

yanrong-chen avatar Jun 05 '24 19:06 yanrong-chen

Builds ready [6e7b8e6]
Page Load Metrics (129 ± 151 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint63166892110
domContentLoaded8311263
load421494129313151
domInteractive8311263
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 4.9 KiB (0.07%)
  • common: 671 Bytes (0.01%)

metamaskbot avatar Jun 06 '24 17:06 metamaskbot

@yanrong-chen I've updated the UI, and addressed the other points as well 👍🏼

Screenshot 2024-06-06 at 14 05 47

Screenshot 2024-06-06 at 14 06 27

zone-live avatar Jun 06 '24 17:06 zone-live

Builds ready [9c76427]
Page Load Metrics (123 ± 154 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint67978084
domContentLoaded9121010
load411520123321154
domInteractive9121010
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 4.9 KiB (0.07%)
  • common: 671 Bytes (0.01%)

metamaskbot avatar Jun 07 '24 09:06 metamaskbot

@zone-live just to double check: were you able to import isProfileSyncingEnabled? This is a new setting and I want to make sure the setting here is consistent with it being added to in-app settings.

cc @matteoscurati

hesterbruikman avatar Jun 11 '24 11:06 hesterbruikman

@zone-live just to double check: were you able to import isProfileSyncingEnabled? This is a new setting and I want to make sure the setting here is consistent with it being added to in-app settings.

cc @matteoscurati

Yap it's there. Screenshot 2024-06-11 at 13 57 40

zone-live avatar Jun 11 '24 13:06 zone-live

Demo video:

https://github.com/MetaMask/metamask-extension/assets/1125631/c6d36853-7401-4ed3-98ef-1468b184972e

zone-live avatar Jun 11 '24 14:06 zone-live

Builds ready [7300c33]
Page Load Metrics (44 ± 3 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint589973105
domContentLoaded814911
load38664473
domInteractive814911
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 4.88 KiB (0.07%)
  • common: 671 Bytes (0.01%)

metamaskbot avatar Jun 12 '24 14:06 metamaskbot

@zone-live Noticed an inconsistency in the copy used for Use phishing detection in the in-app Settings and these Default Settings. Could you please update:

Current Phishing detection alerts rely on communication with jsDeliver. jsDeliver will have access to your IP address. View Privacy policy.

Expected Display a warning for phishing domains targeting Ethereum users.

hesterbruikman avatar Jun 13 '24 09:06 hesterbruikman

@zone-live Noticed an inconsistency in the copy used for Use phishing detection in the in-app Settings and these Default Settings. Could you please update:

Current Phishing detection alerts rely on communication with jsDeliver. jsDeliver will have access to your IP address. View Privacy policy.

Expected Display a warning for phishing domains targeting Ethereum users

Updated 👍🏼 ss_2

zone-live avatar Jun 13 '24 15:06 zone-live

Builds ready [905132a]
Page Load Metrics (58 ± 11 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint7314691188
domContentLoaded10331352
load44146582311
domInteractive10331352
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 1 Bytes (0.00%)
  • ui: 4.58 KiB (0.07%)
  • common: 291 Bytes (0.00%)

metamaskbot avatar Jun 14 '24 08:06 metamaskbot

This looks great @zone-live! Is what remains resolving merge conflicts and another review?

hesterbruikman avatar Jun 14 '24 19:06 hesterbruikman

Builds ready [b5f5b92]
Page Load Metrics (51 ± 7 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint73179892412
domContentLoaded96813136
load4211051147
domInteractive96813136
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 4.58 KiB (0.07%)
  • common: 291 Bytes (0.00%)

metamaskbot avatar Jun 18 '24 09:06 metamaskbot

Builds ready [4665b4d]
Page Load Metrics (47 ± 4 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint589878115
domContentLoaded8211132
load38704794
domInteractive8211132
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 4.61 KiB (0.07%)
  • common: 291 Bytes (0.00%)

metamaskbot avatar Jun 19 '24 09:06 metamaskbot

Builds ready [5becf27]
Page Load Metrics (53 ± 5 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint6913084136
domContentLoaded9211232
load418653105
domInteractive9211232
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 4.58 KiB (0.07%)
  • common: 291 Bytes (0.00%)

metamaskbot avatar Jun 21 '24 14:06 metamaskbot

Quality Gate Passed Quality Gate passed

Issues
5 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarqubecloud[bot] avatar Jul 18 '24 13:07 sonarqubecloud[bot]

Quality Gate Passed Quality Gate passed

Issues
5 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarqubecloud[bot] avatar Sep 04 '24 16:09 sonarqubecloud[bot]

Quality Gate Passed Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
90.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarqubecloud[bot] avatar Oct 08 '24 16:10 sonarqubecloud[bot]

Builds ready [2e3bdcd]
Page Load Metrics (1904 ± 109 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint38726201761430206
domContentLoaded164826101887226108
load168926321904226109
domInteractive21104462411
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 4.99 KiB (0.06%)
  • common: 347 Bytes (0.00%)

metamaskbot avatar Oct 08 '24 17:10 metamaskbot

https://github.com/user-attachments/assets/a9bca766-ca98-4b79-8ef1-af5a88eab51a

Found this odd behaviour, please check out. "You're now using Linea Mainnet 2" toast is shown and automatically closed

jonybur avatar Oct 09 '24 13:10 jonybur