fix: Aurora RPC deprecation message

[bergeron]

Description

Fixes the Aurora deprecation message. It was suggesting MM no longer supports Aurora, which is not true. It's just no longer a built-in network due to Infura no longer supporting it.

Instead, we show a warning to users who previous added it when it was a built-in network. And give them a 1 click migration from Infura to the mainnet.aurora.dev RPC endpoint.

Related issues

Fixes: https://github.com/MetaMask/metamask-extension/issues/23078

Manual testing steps

1. Add the Aurora network via https://chainid.network
2. Verify no deprecation warnings

The RPC migration modal is harder to test. You'd need to have added the network on MM <= 11.6 back when the Infura RPC url was alive.

Screenshots/Recordings

Before

After

Simulating a user who previously added the Infura RPC:

https://github.com/MetaMask/metamask-extension/assets/3500406/6df7591d-284f-47bc-88a3-362174bf141f

Pre-merge author checklist

• [ ] I’ve followed MetaMask Coding Standards.
• [ ] I've completed the PR template to the best of my ability
• [ ] I’ve included tests if applicable
• [ ] I’ve documented my code using JSDoc format if applicable
• [ ] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions[bot]]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[salimtb]

linter and unit tests should be fixed as well

[Karkunow]

@bergeron, Hello, Brian! Thank you for working on this! Just wanted to ask about the ETA of this task - do you have any timeline for its release? Thank you!

[codecov[bot]]

Codecov Report

Attention: Patch coverage is 62.50000% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 65.77%. Comparing base (82fe51c) to head (e097149). Report is 2 commits behind head on develop.

Files	Patch %	Lines
...ents/ui/deprecated-networks/deprecated-networks.js	59.09%	9 Missing :warning:

Additional details and impacted files

@@           Coverage Diff            @@
##           develop   #24534   +/-   ##
========================================
  Coverage    65.77%   65.77%           
========================================
  Files         1366     1366           
  Lines        54238    54236    -2     
  Branches     14108    14110    +2     
========================================
  Hits         35670    35670           
+ Misses       18568    18566    -2     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[metamaskbot]

Builds ready [d3242d3]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (814 ± 547 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	82	161	102	22	11
		domContentLoaded	9	31	14	5	3
		load	68	3433	814	1140	547
		domInteractive	9	31	14	5	3

Bundle size diffs [🚀 Bundle size reduced!]

• background: 0 Bytes (0.00%)
• ui: 389 Bytes (0.01%)
• common: -166 Bytes (-0.00%)