metamask-extension
metamask-extension copied to clipboard
feat: QR-based add OneKey Hardware
Description
Hello, this is the OneKey team.
Our recently released OneKey Pro hardware now supports the EIP-4527 connection method and prioritizes the display of the MetaMask connection method.
Related issues
Fixes:
Manual testing steps
- On your hardware wallet, fetch the QR code for MetaMask
- Proceed to add hardware wallet from the account drop-down selector
- Select QR-based and Continue
- Scan the QR code from the hardware wallet
- user should be able to select QR code account and imported
OneKey Hradware Tutorial Documentation: https://help.onekey.so/hc/articles/9426592069903
Screenshots/Recordings
https://github.com/MetaMask/metamask-extension/assets/92281880/a66a8538-2f24-403a-b9d4-163ecec46c02
Before
After
Pre-merge author checklist
- [x] I’ve followed MetaMask Coding Standards.
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using JSDoc format if applicable
- [ ] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
Pre-merge reviewer checklist
- [x] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
- [x] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.
I have read the CLA Document and I hereby sign the CLA
Has tested with imported with AirGap Vault (since OneKey is airGap compatible
) with importing accounts, connect to dapp, personal sign, Typed sign data v4, send EIP1557 transactions and confirm they all work ok.
LGTM ! Thank you !
OneKey added to the QR-based hardware list:
Codecov Report
Attention: Patch coverage is 25.00000%
with 6 lines
in your changes are missing coverage. Please review.
Project coverage is 67.40%. Comparing base (
c089672
) to head (72fb7cb
).
Files | Patch % | Lines |
---|---|---|
...create-account/connect-hardware/select-hardware.js | 0.00% | 6 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## develop #24492 +/- ##
===========================================
- Coverage 67.41% 67.40% -0.01%
===========================================
Files 1288 1288
Lines 50241 50249 +8
Branches 13013 13013
===========================================
+ Hits 33865 33866 +1
- Misses 16376 16383 +7
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.