metamask-extension icon indicating copy to clipboard operation
metamask-extension copied to clipboard

fix: Signature Redesign Disabled confirm button with missing ScrollToBottom button with 16px or less scroll buffer

Open digiwand opened this issue 1 year ago • 2 comments

Description

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • [ ] I’ve followed MetaMask Coding Standards.
  • [ ] I've completed the PR template to the best of my ability
  • [ ] I’ve included tests if applicable
  • [ ] I’ve documented my code using JSDoc format if applicable
  • [ ] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

digiwand avatar May 10 '24 21:05 digiwand

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] avatar May 10 '24 21:05 github-actions[bot]

Builds ready [2a284d0]
Page Load Metrics (1218 ± 612 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint71142962110
domContentLoaded96619157
load58299812181274612
domInteractive96619157
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 30 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

metamaskbot avatar May 10 '24 21:05 metamaskbot

Builds ready [879f8ef]
Page Load Metrics (787 ± 602 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint7111887157
domContentLoaded9311353
load5732347871253602
domInteractive9311353
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 5 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

metamaskbot avatar May 14 '24 05:05 metamaskbot

Builds ready [879f8ef]
Page Load Metrics (787 ± 602 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint7111887157
domContentLoaded9311353
load5732347871253602
domInteractive9311353
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 5 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

metamaskbot avatar May 14 '24 05:05 metamaskbot

Builds ready [eec6c25]
Page Load Metrics (778 ± 594 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint64149902512
domContentLoaded95418136
load5231897781238594
domInteractive95418136
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 5 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

metamaskbot avatar May 14 '24 13:05 metamaskbot

Codecov Report

Attention: Patch coverage is 83.33333% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 67.48%. Comparing base (cfcbd1e) to head (eec6c25). Report is 3 commits behind head on develop.

Files Patch % Lines
ui/hooks/useScrollRequired.js 80.00% 1 Missing :warning:
...ents/confirm/scroll-to-bottom/scroll-to-bottom.tsx 85.71% 1 Missing :warning:
Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #24489   +/-   ##
========================================
  Coverage    67.48%   67.48%           
========================================
  Files         1288     1288           
  Lines        50153    50158    +5     
  Branches     13023    13025    +2     
========================================
+ Hits         33842    33846    +4     
- Misses       16311    16312    +1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 14 '24 13:05 codecov[bot]