fix: Signature Redesign Disabled confirm button with missing ScrollToBottom button with 16px or less scroll buffer
Description
Related issues
Fixes:
Manual testing steps
- Go to this page...
Screenshots/Recordings
Before
After
Pre-merge author checklist
- [ ] I’ve followed MetaMask Coding Standards.
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using JSDoc format if applicable
- [ ] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
Pre-merge reviewer checklist
- [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.
Builds ready [2a284d0]
- builds: chrome, firefox
- builds (beta): chrome
- builds (flask): chrome, firefox
- builds (MMI): chrome, firefox
- builds (test): chrome, firefox
- builds (test-flask): chrome, firefox
- build viz: Build System
- mv3: Background Module Init Stats
- mv3: UI Init Stats
- mv3: Module Load Stats
- mv3: Bundle Size Stats
- mv2: E2e Actions Stats
- code coverage: Report
- storybook: Storybook
- typescript migration: Dashboard
- all artifacts
Page Load Metrics (1218 ± 612 ms)
| Platform | Page | Metric | Min (ms) | Max (ms) | Average (ms) | StandardDeviation (ms) | MarginOfError (ms) |
|---|---|---|---|---|---|---|---|
| Chrome | Home | firstPaint | 71 | 142 | 96 | 21 | 10 |
| domContentLoaded | 9 | 66 | 19 | 15 | 7 | ||
| load | 58 | 2998 | 1218 | 1274 | 612 | ||
| domInteractive | 9 | 66 | 19 | 15 | 7 |
Bundle size diffs
- background: 0 Bytes (0.00%)
- ui: 30 Bytes (0.00%)
- common: 0 Bytes (0.00%)
Builds ready [879f8ef]
- builds: chrome, firefox
- builds (beta): chrome
- builds (flask): chrome, firefox
- builds (MMI): chrome, firefox
- builds (test): chrome, firefox
- builds (test-flask): chrome, firefox
- build viz: Build System
- mv3: Background Module Init Stats
- mv3: UI Init Stats
- mv3: Module Load Stats
- mv3: Bundle Size Stats
- mv2: E2e Actions Stats
- code coverage: Report
- storybook: Storybook
- typescript migration: Dashboard
- all artifacts
Page Load Metrics (787 ± 602 ms)
| Platform | Page | Metric | Min (ms) | Max (ms) | Average (ms) | StandardDeviation (ms) | MarginOfError (ms) |
|---|---|---|---|---|---|---|---|
| Chrome | Home | firstPaint | 71 | 118 | 87 | 15 | 7 |
| domContentLoaded | 9 | 31 | 13 | 5 | 3 | ||
| load | 57 | 3234 | 787 | 1253 | 602 | ||
| domInteractive | 9 | 31 | 13 | 5 | 3 |
Bundle size diffs
- background: 0 Bytes (0.00%)
- ui: 5 Bytes (0.00%)
- common: 0 Bytes (0.00%)
Builds ready [879f8ef]
- builds: chrome, firefox
- builds (beta): chrome
- builds (flask): chrome, firefox
- builds (MMI): chrome, firefox
- builds (test): chrome, firefox
- builds (test-flask): chrome, firefox
- build viz: Build System
- mv3: Background Module Init Stats
- mv3: UI Init Stats
- mv3: Module Load Stats
- mv3: Bundle Size Stats
- mv2: E2e Actions Stats
- code coverage: Report
- storybook: Storybook
- typescript migration: Dashboard
- all artifacts
Page Load Metrics (787 ± 602 ms)
| Platform | Page | Metric | Min (ms) | Max (ms) | Average (ms) | StandardDeviation (ms) | MarginOfError (ms) |
|---|---|---|---|---|---|---|---|
| Chrome | Home | firstPaint | 71 | 118 | 87 | 15 | 7 |
| domContentLoaded | 9 | 31 | 13 | 5 | 3 | ||
| load | 57 | 3234 | 787 | 1253 | 602 | ||
| domInteractive | 9 | 31 | 13 | 5 | 3 |
Bundle size diffs
- background: 0 Bytes (0.00%)
- ui: 5 Bytes (0.00%)
- common: 0 Bytes (0.00%)
Builds ready [eec6c25]
- builds: chrome, firefox
- builds (beta): chrome
- builds (flask): chrome, firefox
- builds (MMI): chrome, firefox
- builds (test): chrome, firefox
- builds (test-flask): chrome, firefox
- build viz: Build System
- mv3: Background Module Init Stats
- mv3: UI Init Stats
- mv3: Module Load Stats
- mv3: Bundle Size Stats
- mv2: E2e Actions Stats
- code coverage: Report
- storybook: Storybook
- typescript migration: Dashboard
- all artifacts
Page Load Metrics (778 ± 594 ms)
| Platform | Page | Metric | Min (ms) | Max (ms) | Average (ms) | StandardDeviation (ms) | MarginOfError (ms) |
|---|---|---|---|---|---|---|---|
| Chrome | Home | firstPaint | 64 | 149 | 90 | 25 | 12 |
| domContentLoaded | 9 | 54 | 18 | 13 | 6 | ||
| load | 52 | 3189 | 778 | 1238 | 594 | ||
| domInteractive | 9 | 54 | 18 | 13 | 6 |
Bundle size diffs
- background: 0 Bytes (0.00%)
- ui: 5 Bytes (0.00%)
- common: 0 Bytes (0.00%)
Codecov Report
Attention: Patch coverage is 83.33333% with 2 lines in your changes are missing coverage. Please review.
Project coverage is 67.48%. Comparing base (
cfcbd1e) to head (eec6c25). Report is 3 commits behind head on develop.
| Files | Patch % | Lines |
|---|---|---|
| ui/hooks/useScrollRequired.js | 80.00% | 1 Missing :warning: |
| ...ents/confirm/scroll-to-bottom/scroll-to-bottom.tsx | 85.71% | 1 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## develop #24489 +/- ##
========================================
Coverage 67.48% 67.48%
========================================
Files 1288 1288
Lines 50153 50158 +5
Branches 13023 13025 +2
========================================
+ Hits 33842 33846 +4
- Misses 16311 16312 +1
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.