metamask-extension icon indicating copy to clipboard operation
metamask-extension copied to clipboard

chore(test/e2e): Fix onboarding/onboarding.spec.js

Open vthomas13 opened this issue 9 months ago • 1 comments

Description

Flaky test: "MetaMask onboarding @no-mmi Verify that the user has been redirected to the correct page after creating a password for their new wallet"
Attempting to fix by adding await driver.findElement('[data-testid="create-password-new"]');before trying to fill.

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • [ ] I’ve followed MetaMask Coding Standards.
  • [ ] I've completed the PR template to the best of my ability
  • [ ] I’ve included tests if applicable
  • [ ] I’ve documented my code using JSDoc format if applicable
  • [ ] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

vthomas13 avatar May 10 '24 19:05 vthomas13

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] avatar May 10 '24 19:05 github-actions[bot]

Builds ready [e6e98e6]
Page Load Metrics (1005 ± 626 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint682581134924
domContentLoaded997192010
load57343010051303626
domInteractive997192010
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

metamaskbot avatar May 28 '24 14:05 metamaskbot

Builds ready [1e9ec7b]
Page Load Metrics (812 ± 548 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint652081013718
domContentLoaded95015115
load5331758121142548
domInteractive95015115
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

metamaskbot avatar May 29 '24 16:05 metamaskbot

Builds ready [d5cacf6]
Page Load Metrics (55 ± 8 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint6914184157
domContentLoaded9191121
load4211755178
domInteractive9191121

metamaskbot avatar Jun 03 '24 14:06 metamaskbot