metamask-extension icon indicating copy to clipboard operation
metamask-extension copied to clipboard

Add ui_customizations "redesigned_confirmation" metric for transactions

Open digiwand opened this issue 1 year ago • 0 comments

What is this about?

Currently, we add the ui_customizations "redesigned_confirmation" event property for redesigned signatures. This happens in createRPCMethodTrackingMiddleware.js. We will need to add the same property for redesigned transactions.

A challenge with doing this in createRPCMethodTrackingMiddleware.js is that the method we check is the eth method. For the contract interaction transaction type, the method would equal eth_call. We can consider using updateTransactionEventFragment for the solution.

Repro:

  1. set ENABLE_CONFIRMATION_REDESIGN=true in .metamaskrc
  2. enable Experimental > Redesign Confirmation in settings
  3. enable Participate in MetaMetrics in settings
  4. test redesigned transactions (Contract Interaction) e.g. test-dapp Mint NFT
  5. observe "Transaction <Rejected|Canceled|Approved>" event with new ui_customizations

Scenario

No response

Design

No response

Technical Details

No response

Threat Modeling Framework

No response

Acceptance Criteria

No response

Stakeholder review needed before the work gets merged

  • [ ] Engineering (needed in most cases)
  • [ ] Design
  • [ ] Product
  • [ ] QA (automation tests are required to pass before merging PRs but not all changes are covered by automation tests - please review if QA is needed beyond automation tests)
  • [ ] Security
  • [ ] Legal
  • [ ] Marketing
  • [ ] Management (please specify)
  • [ ] Other (please specify)

References

No response

digiwand avatar May 10 '24 17:05 digiwand