metamask-extension icon indicating copy to clipboard operation
metamask-extension copied to clipboard

fix: signature redesign ui_customizations metric

Open digiwand opened this issue 1 year ago • 1 comments

Description

Open in GitHub Codespaces

Related issues

Fixes: https://github.com/MetaMask/metamask-extension/issues/24483

Manual testing steps

  1. set ENABLE_CONFIRMATION_REDESIGN=true in .metamaskrc
  2. enable Experimental > Redesign Confirmation in settings
  3. enable Participate in MetaMetrics in settings
  4. test signatures
  5. observe Signature <Rejected|Canceled|Approved> event with new ui_customization

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • [ ] I’ve followed MetaMask Coding Standards.
  • [ ] I've completed the PR template to the best of my ability
  • [ ] I’ve included tests if applicable
  • [ ] I’ve documented my code using JSDoc format if applicable
  • [ ] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

digiwand avatar May 10 '24 13:05 digiwand

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] avatar May 10 '24 13:05 github-actions[bot]

sorry I should start running yarn lint locally before requesting reviews 🤦🏼‍♀️ @cryptotavares @jpuri

digiwand avatar May 13 '24 16:05 digiwand

Builds ready [39f5866]
Page Load Metrics (2093 ± 724 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint722071213718
domContentLoaded94017105
load59421020931507724
domInteractive94017105
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 438 Bytes (0.01%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

metamaskbot avatar May 14 '24 03:05 metamaskbot

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 67.49%. Comparing base (98d5ff2) to head (39f5866). Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #24484      +/-   ##
===========================================
+ Coverage    67.47%   67.49%   +0.01%     
===========================================
  Files         1288     1288              
  Lines        50154    50151       -3     
  Branches     13023    13018       -5     
===========================================
+ Hits         33841    33845       +4     
+ Misses       16313    16306       -7     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 14 '24 03:05 codecov[bot]

No release label on PR. Adding release label release-11.17.0 on PR, as PR was cherry-picked in branch 11.17.0.

metamaskbot avatar May 23 '24 23:05 metamaskbot