fix: signature redesign ui_customizations metric
Description
Related issues
Fixes: https://github.com/MetaMask/metamask-extension/issues/24483
Manual testing steps
- set
ENABLE_CONFIRMATION_REDESIGN=truein .metamaskrc - enable Experimental > Redesign Confirmation in settings
- enable Participate in MetaMetrics in settings
- test signatures
- observe Signature <Rejected|Canceled|Approved> event with new ui_customization
Screenshots/Recordings
Before
After
Pre-merge author checklist
- [ ] I’ve followed MetaMask Coding Standards.
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using JSDoc format if applicable
- [ ] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
Pre-merge reviewer checklist
- [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.
sorry I should start running yarn lint locally before requesting reviews 🤦🏼♀️ @cryptotavares @jpuri
Builds ready [39f5866]
- builds: chrome, firefox
- builds (beta): chrome
- builds (flask): chrome, firefox
- builds (MMI): chrome, firefox
- builds (test): chrome, firefox
- builds (test-flask): chrome, firefox
- build viz: Build System
- mv3: Background Module Init Stats
- mv3: UI Init Stats
- mv3: Module Load Stats
- mv3: Bundle Size Stats
- mv2: E2e Actions Stats
- code coverage: Report
- storybook: Storybook
- typescript migration: Dashboard
- all artifacts
Page Load Metrics (2093 ± 724 ms)
| Platform | Page | Metric | Min (ms) | Max (ms) | Average (ms) | StandardDeviation (ms) | MarginOfError (ms) |
|---|---|---|---|---|---|---|---|
| Chrome | Home | firstPaint | 72 | 207 | 121 | 37 | 18 |
| domContentLoaded | 9 | 40 | 17 | 10 | 5 | ||
| load | 59 | 4210 | 2093 | 1507 | 724 | ||
| domInteractive | 9 | 40 | 17 | 10 | 5 |
Bundle size diffs [🚨 Warning! Bundle size has increased!]
- background: 438 Bytes (0.01%)
- ui: 0 Bytes (0.00%)
- common: 0 Bytes (0.00%)
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 67.49%. Comparing base (
98d5ff2) to head (39f5866). Report is 2 commits behind head on develop.
Additional details and impacted files
@@ Coverage Diff @@
## develop #24484 +/- ##
===========================================
+ Coverage 67.47% 67.49% +0.01%
===========================================
Files 1288 1288
Lines 50154 50151 -3
Branches 13023 13018 -5
===========================================
+ Hits 33841 33845 +4
+ Misses 16313 16306 -7
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
No release label on PR. Adding release label release-11.17.0 on PR, as PR was cherry-picked in branch 11.17.0.