metamask-extension icon indicating copy to clipboard operation
metamask-extension copied to clipboard

Published 20 hours ago • verified publisher icon MetaMask

[Bug]: Certain chains icons are not displayed in the Send flow

Open sleepytanya opened this issue 9 months ago • 1 comments

Describe the bug

BNB Chain and Linea Mainnet icons are not displayed in the Send flow.

Expected behavior

Network icons are properly displayed.

Screenshots/Recordings

Screenshot 2024-05-08 at 21 50 49 linea

Steps to reproduce

  1. Switch to BNB Chain / Linea Mainnet
  2. Start Send transaction
  3. Notice that BNB / Linea network icon is not displayed in the Send flow

Error messages or log output

No response

Version

latest build

Build type

None

Browser

Chrome, Firefox

Operating system

MacOS

Hardware wallet

No response

Additional context

No response

Severity

No response

sleepytanya avatar May 09 '24 01:05 sleepytanya

Seeing this in develop as well – downgrading from a blocker

BZahory avatar May 10 '24 16:05 BZahory

Latest build Slack discussion link. Chrome - Linea mainnet and BNB Chain icons displayed correctly: Screenshot 2024-06-07 at 00 25 30

sleepytanya avatar Jun 07 '24 04:06 sleepytanya

Is this within the scope of Swap+Send? It seems like a general/confirmations bug

BZahory avatar Jun 07 '24 08:06 BZahory

Icons for BNB Chain and Linea Mainnet not disaplyed, tested on the latest send+swap build and develop:

Screenshot 2024-06-10 at 13 45 32 Screenshot 2024-06-10 at 13 45 11 Screenshot 2024-06-10 at 13 44 25

sleepytanya avatar Jun 10 '24 17:06 sleepytanya

Looks like the network icons are still missing, but the tokens are correctly showing or at least displaying an icon other than ? Screenshot 2024-06-25 at 11 33 50

NVM it seem the token badges were resolved in https://github.com/MetaMask/metamask-extension/pull/25470

ejwessel avatar Jun 25 '24 18:06 ejwessel

Closed by https://github.com/MetaMask/metamask-extension/pull/25470

sleepytanya avatar Jun 25 '24 20:06 sleepytanya

Closing in lieu of https://github.com/MetaMask/metamask-extension/issues/25447

ejwessel avatar Jun 25 '24 22:06 ejwessel

https://github.com/MetaMask/metamask-extension/pull/25518

ejwessel avatar Jun 26 '24 00:06 ejwessel

This bug is present in v12.0.0 beta:

Screenshot 2024-07-15 at 21 53 43 Screenshot 2024-07-15 at 21 55 30

sleepytanya avatar Jul 16 '24 01:07 sleepytanya

@sleepytanya Is the problem still present on the Send screen? Or only now on the confirmation screen?

danjm avatar Jul 17 '24 13:07 danjm

@danjm It affects only Confirmation screen.

sleepytanya avatar Jul 17 '24 21:07 sleepytanya

I think this PR https://github.com/MetaMask/metamask-extension/pull/25518 might fix it, but was not cherry picked to v12.0. That being said, it's not a regression (it's also present on v11.16.4) so shouldn't be considered a release blocker.

bschorchit avatar Jul 23 '24 16:07 bschorchit

Reverting labels as discussed in release sync as the original issue was slightly different than the latest and was cherry picked to the release.

bschorchit avatar Jul 23 '24 16:07 bschorchit

Closing as the original issue has been fixed to facilitate v12.0 bug triage. We can open a separate one for the confirmation specific issue.

bschorchit avatar Jul 23 '24 17:07 bschorchit