metamask-extension icon indicating copy to clipboard operation
metamask-extension copied to clipboard

test: Basic Functionality Toggle - Follow-up

Open vthomas13 opened this issue 9 months ago • 2 comments

Description

Follows up on #23456 with some unit/e2e tests, and some implemented feedback for the Basic Functionality Toggle.

Open in GitHub Codespaces

Related issues

Fixes: #23456

Manual testing steps

See #23456

Screenshots/Recordings

No change

Before

After

Pre-merge author checklist

  • [X] I’ve followed MetaMask Coding Standards.
  • [X] I've completed the PR template to the best of my ability
  • [X] I’ve included tests if applicable
  • [X] I’ve documented my code using JSDoc format if applicable
  • [X] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

vthomas13 avatar May 07 '24 16:05 vthomas13

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] avatar May 07 '24 16:05 github-actions[bot]

Could this failure also be addressed? When running locally it looks like changes from #23456 interfere with the existing tests.

legobeat avatar May 07 '24 20:05 legobeat

Builds ready [34220e2]
Page Load Metrics (1144 ± 643 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint67143912412
domContentLoaded95515105
load54335311441339643
domInteractive95515105
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 87 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

metamaskbot avatar May 08 '24 19:05 metamaskbot

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 67.37%. Comparing base (ed850ee) to head (34220e2).

Files Patch % Lines
...-configuration-modal/basic-configuration-modal.tsx 0.00% 3 Missing :warning:
Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #24413   +/-   ##
========================================
  Coverage    67.37%   67.37%           
========================================
  Files         1286     1286           
  Lines        50114    50113    -1     
  Branches     13004    13002    -2     
========================================
  Hits         33761    33761           
+ Misses       16353    16352    -1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 08 '24 19:05 codecov[bot]

Missing release label release-11.16.6 on PR. Adding release label release-11.16.6 on PR and removing other release labels(release-11.17.0), as PR was cherry-picked in branch 11.16.6.

metamaskbot avatar Jun 04 '24 20:06 metamaskbot