metamask-extension icon indicating copy to clipboard operation
metamask-extension copied to clipboard

refactor: remove whats new notification for staking

Open jclancy93 opened this issue 9 months ago • 2 comments

Description

Removes what's new notification for direct staking within MetaMask. This notification is being removed because it has been there for some time now and our team has been asked to remove it by May 9th

Open in GitHub Codespaces

Related issues

Fixes: STAKE-689

Manual testing steps

  1. Install or update extension
  2. View what's new modal
  3. Confirm that staking notification is no longer there

Screenshots/Recordings

Before

https://www.loom.com/share/bd5aee8a123e4e1c8d76bbd89a22c32b

After

https://www.loom.com/share/73c1e2924271431c8a98c8aed07da4dc

Pre-merge author checklist

  • [x] I’ve followed MetaMask Coding Standards.
  • [x] I've completed the PR template to the best of my ability
  • [ ] I’ve included tests if applicable
  • [ ] I’ve documented my code using JSDoc format if applicable
  • [x] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • [x] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • [x] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

jclancy93 avatar May 07 '24 09:05 jclancy93

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] avatar May 07 '24 09:05 github-actions[bot]

I have read the CLA Document and I hereby sign the CLA

jclancy93 avatar May 07 '24 10:05 jclancy93

Builds ready [2193955]
Page Load Metrics (1524 ± 772 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint652251204120
domContentLoaded106822157
load51402015241608772
domInteractive106822157
Bundle size diffs [🚀 Bundle size reduced!]
  • background: 0 Bytes (0.00%)
  • ui: -151 Bytes (-0.00%)
  • common: -1.05 KiB (-0.02%)

metamaskbot avatar May 14 '24 18:05 metamaskbot