fix: gas fee editing in advance gas fee modals

[jpuri]

Description

Fix for user unable to manually edit gas fee in advance gas fee editing modal.

Related issues

Fixes: https://github.com/MetaMask/metamask-extension/issues/24260

Manual testing steps

1. Go to advance gas fee editing modal
2. Manually edit gas fee
3. New edited gas value should be retained

Screenshots/Recordings

Before

After

Pre-merge author checklist

• [X] I’ve followed MetaMask Coding Standards.
• [X] I've completed the PR template to the best of my ability
• [X] I’ve included tests if applicable
• [ ] I’ve documented my code using JSDoc format if applicable
• [X] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions[bot]]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[sleepytanya]

@jpuri Works great! When users manually edit the gas fee for a transaction, this edited amount remains unchanged when there are updates to gas fee calculations (dev build (d2fe3c0)):

https://github.com/MetaMask/metamask-extension/assets/104780023/882d9dab-a742-434f-a852-77a31726428e

The same error is present on develop, unrelated to current PR.

[metamaskbot]

Builds ready [d2fe3c0]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8
  • content-script: 0
  • ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (806 ± 616 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	60	165	87	25	12
		domContentLoaded	9	29	13	5	2
		load	48	3364	806	1283	616
		domInteractive	9	29	13	5	2

Bundle size diffs

• background: 0 Bytes (0.00%)
• ui: 72 Bytes (0.00%)
• common: 0 Bytes (0.00%)

[codecov[bot]]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 67.35%. Comparing base (d27a233) to head (d2fe3c0). Report is 22 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #24387      +/-   ##
===========================================
- Coverage    67.37%   67.35%   -0.02%     
===========================================
  Files         1278     1282       +4     
  Lines        49881    50069     +188     
  Branches     12944    12990      +46     
===========================================
+ Hits         33605    33720     +115     
- Misses       16276    16349      +73     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[metamaskbot]

Missing release label release-11.17.0 on PR. Adding release label release-11.17.0 on PR and removing other release labels(release-11.18.0), as PR was added to branch 11.17.0 when release was cut.