metamask-extension icon indicating copy to clipboard operation
metamask-extension copied to clipboard

revert: deprecating more networks (#23695)

Open salimtb opened this issue 10 months ago • 5 comments

This reverts commit 257e9f9fce04ae4581215c1f756be40ce4e39113.

Description

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • [ ] I’ve followed MetaMask Coding Standards.
  • [ ] I've completed the PR template to the best of my ability
  • [ ] I’ve included tests if applicable
  • [ ] I’ve documented my code using JSDoc format if applicable
  • [ ] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

salimtb avatar May 03 '24 16:05 salimtb

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] avatar May 03 '24 16:05 github-actions[bot]

Builds ready [af2eab9]
Page Load Metrics (341 ± 406 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint6212678157
domContentLoaded95613105
load513163341845406
domInteractive95613105
Bundle size diffs [🚀 Bundle size reduced!]
  • background: -2.04 KiB (-0.05%)
  • ui: 356 Bytes (0.01%)
  • common: 302 Bytes (0.00%)

metamaskbot avatar May 06 '24 09:05 metamaskbot

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 67.29%. Comparing base (e775193) to head (50aae8e).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #24369      +/-   ##
===========================================
- Coverage    67.36%   67.29%   -0.07%     
===========================================
  Files         1282     1282              
  Lines        50011    49991      -20     
  Branches     12983    12971      -12     
===========================================
- Hits         33685    33638      -47     
- Misses       16326    16353      +27     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 06 '24 09:05 codecov[bot]

Builds ready [5b08f80]
Page Load Metrics (983 ± 610 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint58145852211
domContentLoaded85515115
load4733599831271610
domInteractive85515115
Bundle size diffs [🚀 Bundle size reduced!]
  • background: -2.04 KiB (-0.05%)
  • ui: 356 Bytes (0.01%)
  • common: 302 Bytes (0.00%)

metamaskbot avatar May 06 '24 19:05 metamaskbot

LGTM

sahar-fehri avatar May 07 '24 18:05 sahar-fehri

Builds ready [50aae8e]
Page Load Metrics (1226 ± 706 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint60173922914
domContentLoaded9391484
load48441312261469706
domInteractive9391484
Bundle size diffs [🚀 Bundle size reduced!]
  • background: -1.49 KiB (-0.04%)
  • ui: 356 Bytes (0.01%)
  • common: 302 Bytes (0.00%)

metamaskbot avatar May 14 '24 16:05 metamaskbot