metamask-extension
metamask-extension copied to clipboard
revert: deprecating more networks (#23695)
This reverts commit 257e9f9fce04ae4581215c1f756be40ce4e39113.
Description
Related issues
Fixes:
Manual testing steps
- Go to this page...
Screenshots/Recordings
Before
After
Pre-merge author checklist
- [ ] I’ve followed MetaMask Coding Standards.
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using JSDoc format if applicable
- [ ] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
Pre-merge reviewer checklist
- [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.
Builds ready [af2eab9]
- builds: chrome, firefox
- builds (beta): chrome
- builds (flask): chrome, firefox
- builds (MMI): chrome, firefox
- builds (test): chrome, firefox
- builds (test-flask): chrome, firefox
- build viz: Build System
- mv3: Background Module Init Stats
- mv3: UI Init Stats
- mv3: Module Load Stats
- mv3: Bundle Size Stats
- mv2: E2e Actions Stats
- code coverage: Report
- storybook: Storybook
- typescript migration: Dashboard
- all artifacts
Page Load Metrics (341 ± 406 ms)
Platform | Page | Metric | Min (ms) | Max (ms) | Average (ms) | StandardDeviation (ms) | MarginOfError (ms) |
---|---|---|---|---|---|---|---|
Chrome | Home | firstPaint | 62 | 126 | 78 | 15 | 7 |
domContentLoaded | 9 | 56 | 13 | 10 | 5 | ||
load | 51 | 3163 | 341 | 845 | 406 | ||
domInteractive | 9 | 56 | 13 | 10 | 5 |
Bundle size diffs [🚀 Bundle size reduced!]
- background: -2.04 KiB (-0.05%)
- ui: 356 Bytes (0.01%)
- common: 302 Bytes (0.00%)
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 67.29%. Comparing base (
e775193
) to head (50aae8e
).
Additional details and impacted files
@@ Coverage Diff @@
## develop #24369 +/- ##
===========================================
- Coverage 67.36% 67.29% -0.07%
===========================================
Files 1282 1282
Lines 50011 49991 -20
Branches 12983 12971 -12
===========================================
- Hits 33685 33638 -47
- Misses 16326 16353 +27
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Builds ready [5b08f80]
- builds: chrome, firefox
- builds (beta): chrome
- builds (flask): chrome, firefox
- builds (MMI): chrome, firefox
- builds (test): chrome, firefox
- builds (test-flask): chrome, firefox
- build viz: Build System
- mv3: Background Module Init Stats
- mv3: UI Init Stats
- mv3: Module Load Stats
- mv3: Bundle Size Stats
- mv2: E2e Actions Stats
- code coverage: Report
- storybook: Storybook
- typescript migration: Dashboard
- all artifacts
Page Load Metrics (983 ± 610 ms)
Platform | Page | Metric | Min (ms) | Max (ms) | Average (ms) | StandardDeviation (ms) | MarginOfError (ms) |
---|---|---|---|---|---|---|---|
Chrome | Home | firstPaint | 58 | 145 | 85 | 22 | 11 |
domContentLoaded | 8 | 55 | 15 | 11 | 5 | ||
load | 47 | 3359 | 983 | 1271 | 610 | ||
domInteractive | 8 | 55 | 15 | 11 | 5 |
Bundle size diffs [🚀 Bundle size reduced!]
- background: -2.04 KiB (-0.05%)
- ui: 356 Bytes (0.01%)
- common: 302 Bytes (0.00%)
LGTM
Builds ready [50aae8e]
- builds: chrome, firefox
- builds (beta): chrome
- builds (flask): chrome, firefox
- builds (MMI): chrome, firefox
- builds (test): chrome, firefox
- builds (test-flask): chrome, firefox
- build viz: Build System
- mv3: Background Module Init Stats
- mv3: UI Init Stats
- mv3: Module Load Stats
- mv3: Bundle Size Stats
- mv2: E2e Actions Stats
- code coverage: Report
- storybook: Storybook
- typescript migration: Dashboard
- all artifacts
Page Load Metrics (1226 ± 706 ms)
Platform | Page | Metric | Min (ms) | Max (ms) | Average (ms) | StandardDeviation (ms) | MarginOfError (ms) |
---|---|---|---|---|---|---|---|
Chrome | Home | firstPaint | 60 | 173 | 92 | 29 | 14 |
domContentLoaded | 9 | 39 | 14 | 8 | 4 | ||
load | 48 | 4413 | 1226 | 1469 | 706 | ||
domInteractive | 9 | 39 | 14 | 8 | 4 |
Bundle size diffs [🚀 Bundle size reduced!]
- background: -1.49 KiB (-0.04%)
- ui: 356 Bytes (0.01%)
- common: 302 Bytes (0.00%)