metamask-extension icon indicating copy to clipboard operation
metamask-extension copied to clipboard

feat: Removed multichain flag for v1 release

Open NidhiKJha opened this issue 10 months ago • 3 comments

This PR is to remove all the Multichain flags from code except the send and swap flow

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/2431

Manual testing steps

  1. Run the extension without Multichain flag.
  2. All the changes should be there

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • [ ] I’ve followed MetaMask Coding Standards.
  • [ ] I've completed the PR template to the best of my ability
  • [ ] I’ve included tests if applicable
  • [ ] I’ve documented my code using JSDoc format if applicable
  • [ ] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

NidhiKJha avatar May 03 '24 11:05 NidhiKJha

@NidhiKJha you have 1 broken unit test

salimtb avatar May 06 '24 19:05 salimtb

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] avatar May 07 '24 19:05 github-actions[bot]

I'm not sure if 'Select networks for each site' in Experimental settings should be ON by default? Seems like multichain doesn't work correctly? Sorry, if I'm missing something :).

https://github.com/MetaMask/metamask-extension/assets/104780023/a7056a1c-0876-46d5-9edc-978a3ac7b49e

sleepytanya avatar May 08 '24 03:05 sleepytanya

Codecov Report

Attention: Patch coverage is 30.00000% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 67.45%. Comparing base (ed850ee) to head (ef8a63d).

Files Patch % Lines
ui/index.js 0.00% 12 Missing :warning:
ui/components/multichain/app-header/app-header.js 0.00% 1 Missing :warning:
...i/components/multichain/global-menu/global-menu.js 0.00% 1 Missing :warning:
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #24362      +/-   ##
===========================================
+ Coverage    67.37%   67.45%   +0.08%     
===========================================
  Files         1286     1286              
  Lines        50114    50077      -37     
  Branches     13004    12985      -19     
===========================================
+ Hits         33761    33777      +16     
+ Misses       16353    16300      -53     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 08 '24 12:05 codecov[bot]

Builds ready [3f07521]
Page Load Metrics (944 ± 636 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint701831062814
domContentLoaded96623168
load5633899441324636
domInteractive96623168
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 529 Bytes (0.01%)
  • common: 96 Bytes (0.00%)

metamaskbot avatar May 08 '24 16:05 metamaskbot

Builds ready [ef8a63d]
Page Load Metrics (659 ± 494 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint7012787168
domContentLoaded9441794
load5626266591029494
domInteractive9441794
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 938 Bytes (0.01%)
  • common: 96 Bytes (0.00%)

metamaskbot avatar May 08 '24 19:05 metamaskbot

Missing release label release-11.17.0 on PR. Adding release label release-11.17.0 on PR and removing other release labels(release-11.18.0), as PR was added to branch 11.17.0 when release was cut.

metamaskbot avatar May 23 '24 23:05 metamaskbot