metamask-extension
metamask-extension copied to clipboard
feat: Removed multichain flag for v1 release
This PR is to remove all the Multichain flags from code except the send and swap flow
Related issues
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/2431
Manual testing steps
- Run the extension without Multichain flag.
- All the changes should be there
Screenshots/Recordings
Before
After
Pre-merge author checklist
- [ ] I’ve followed MetaMask Coding Standards.
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using JSDoc format if applicable
- [ ] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
Pre-merge reviewer checklist
- [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
@NidhiKJha you have 1 broken unit test
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.
I'm not sure if 'Select networks for each site' in Experimental settings should be ON by default? Seems like multichain doesn't work correctly? Sorry, if I'm missing something :).
https://github.com/MetaMask/metamask-extension/assets/104780023/a7056a1c-0876-46d5-9edc-978a3ac7b49e
Codecov Report
Attention: Patch coverage is 30.00000%
with 14 lines
in your changes are missing coverage. Please review.
Project coverage is 67.45%. Comparing base (
ed850ee
) to head (ef8a63d
).
Additional details and impacted files
@@ Coverage Diff @@
## develop #24362 +/- ##
===========================================
+ Coverage 67.37% 67.45% +0.08%
===========================================
Files 1286 1286
Lines 50114 50077 -37
Branches 13004 12985 -19
===========================================
+ Hits 33761 33777 +16
+ Misses 16353 16300 -53
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Builds ready [3f07521]
- builds: chrome, firefox
- builds (beta): chrome
- builds (flask): chrome, firefox
- builds (MMI): chrome, firefox
- builds (test): chrome, firefox
- builds (test-flask): chrome, firefox
- build viz: Build System
- mv3: Background Module Init Stats
- mv3: UI Init Stats
- mv3: Module Load Stats
- mv3: Bundle Size Stats
- mv2: E2e Actions Stats
- code coverage: Report
- storybook: Storybook
- typescript migration: Dashboard
- all artifacts
Page Load Metrics (944 ± 636 ms)
Platform | Page | Metric | Min (ms) | Max (ms) | Average (ms) | StandardDeviation (ms) | MarginOfError (ms) |
---|---|---|---|---|---|---|---|
Chrome | Home | firstPaint | 70 | 183 | 106 | 28 | 14 |
domContentLoaded | 9 | 66 | 23 | 16 | 8 | ||
load | 56 | 3389 | 944 | 1324 | 636 | ||
domInteractive | 9 | 66 | 23 | 16 | 8 |
Bundle size diffs [🚨 Warning! Bundle size has increased!]
- background: 0 Bytes (0.00%)
- ui: 529 Bytes (0.01%)
- common: 96 Bytes (0.00%)
Builds ready [ef8a63d]
- builds: chrome, firefox
- builds (beta): chrome
- builds (flask): chrome, firefox
- builds (MMI): chrome, firefox
- builds (test): chrome, firefox
- builds (test-flask): chrome, firefox
- build viz: Build System
- mv3: Background Module Init Stats
- mv3: UI Init Stats
- mv3: Module Load Stats
- mv3: Bundle Size Stats
- mv2: E2e Actions Stats
- code coverage: Report
- storybook: Storybook
- typescript migration: Dashboard
- all artifacts
Page Load Metrics (659 ± 494 ms)
Platform | Page | Metric | Min (ms) | Max (ms) | Average (ms) | StandardDeviation (ms) | MarginOfError (ms) |
---|---|---|---|---|---|---|---|
Chrome | Home | firstPaint | 70 | 127 | 87 | 16 | 8 |
domContentLoaded | 9 | 44 | 17 | 9 | 4 | ||
load | 56 | 2626 | 659 | 1029 | 494 | ||
domInteractive | 9 | 44 | 17 | 9 | 4 |
Bundle size diffs [🚨 Warning! Bundle size has increased!]
- background: 0 Bytes (0.00%)
- ui: 938 Bytes (0.01%)
- common: 96 Bytes (0.00%)
Missing release label release-11.17.0 on PR. Adding release label release-11.17.0 on PR and removing other release labels(release-11.18.0), as PR was added to branch 11.17.0 when release was cut.