metamask-extension icon indicating copy to clipboard operation
metamask-extension copied to clipboard

feat: Add blockaid validation support for OPBNB network.

Open jpuri opened this issue 9 months ago • 4 comments

Description

Add blockaid validation support for OPBNB network.

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/2392

Manual testing steps

  1. Switch to opBNB network
  2. Submit transaction
  3. Ensure blockaid validation is done

Screenshots/Recordings

Screenshot 2024-05-03 at 5 23 10 PM

Pre-merge author checklist

  • [X] I’ve followed MetaMask Coding Standards.
  • [X] I've completed the PR template to the best of my ability
  • [X] I’ve included tests if applicable
  • [ ] I’ve documented my code using JSDoc format if applicable
  • [X] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

jpuri avatar May 03 '24 11:05 jpuri

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] avatar May 03 '24 11:05 github-actions[bot]

Looks great from QA side! Dev build b19af64

Screenshot 2024-05-06 at 17 04 28

sleepytanya avatar May 06 '24 21:05 sleepytanya

Builds ready [b19af64]
Page Load Metrics (723 ± 546 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint56142892612
domContentLoaded85518147
load4528287231136546
domInteractive85518147
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 13 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 87 Bytes (0.00%)

metamaskbot avatar May 07 '24 07:05 metamaskbot

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 67.34%. Comparing base (f0ac9c0) to head (6ccc595). Report is 11 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #24361   +/-   ##
========================================
  Coverage    67.34%   67.34%           
========================================
  Files         1282     1282           
  Lines        50066    50067    +1     
  Branches     12986    12986           
========================================
+ Hits         33716    33717    +1     
  Misses       16350    16350           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 07 '24 07:05 codecov[bot]

Builds ready [6ccc595]
Page Load Metrics (596 ± 510 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint5612380136
domContentLoaded8221442
load4529645961063510
domInteractive8221442
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 13 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 87 Bytes (0.00%)

metamaskbot avatar May 08 '24 08:05 metamaskbot

Missing release label release-11.17.0 on PR. Adding release label release-11.17.0 on PR and removing other release labels(release-11.18.0), as PR was added to branch 11.17.0 when release was cut.

metamaskbot avatar May 23 '24 23:05 metamaskbot