metamask-extension icon indicating copy to clipboard operation
metamask-extension copied to clipboard

Published 20 hours ago • verified publisher icon MetaMask

test: Signature Redesign e2e tests for each supported signature type

Open digiwand opened this issue 1 year ago • 7 comments

Description

Open in GitHub Codespaces

Related issues

Fixes: https://github.com/MetaMask/metamask-extension/issues/23977 Blocked By: https://github.com/MetaMask/metamask-extension/issues/24712

Manual testing steps

  1. set ENABLE_CONFIRMATION_REDESIGN=true in .metamaskrc
  2. enable Experimental > "Improved signature requests" in settings
  3. test signatures in test-dapp

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • [ ] I’ve followed MetaMask Coding Standards.
  • [ ] I've completed the PR template to the best of my ability
  • [ ] I’ve included tests if applicable
  • [ ] I’ve documented my code using JSDoc format if applicable
  • [ ] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

digiwand avatar May 02 '24 15:05 digiwand

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] avatar May 02 '24 15:05 github-actions[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 65.70%. Comparing base (07f1eb4) to head (6e183cb).

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop   #24352      +/-   ##
===========================================
- Coverage    65.70%   65.70%   -0.00%     
===========================================
  Files         1366     1366              
  Lines        54361    54361              
  Branches     14141    14141              
===========================================
- Hits         35715    35714       -1     
- Misses       18646    18647       +1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 08 '24 00:05 codecov[bot]

Possible to loom through various signatures, rather than adding a separate spec for each ?

jpuri avatar May 09 '24 08:05 jpuri

Hi @jpuri, this was a consideration. Discussed this with @pedronfigueiredo and @pnarayanaswamy. We've been leaning towards keeping files per type. I'm open to other considerations. This said, @pnarayanaswamy has created a followup PR to refactor our tests and combine them together here https://github.com/MetaMask/metamask-extension/pull/24424

digiwand avatar May 09 '24 11:05 digiwand

somehow, this unit test failed in this PR https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/80783/workflows/9be32d3b-80da-41b8-8cfd-1d837f57871b/jobs/2855569

CleanShot 2024-05-15 at 15 56 28@2x

we should double-check this is not a flaky test separately from this PR cc: @jpuri

digiwand avatar May 15 '24 22:05 digiwand

https://app.circleci.com/jobs/github/MetaMask/metamask-extension/2855977

failing on the chrome-confirmation-redesign builds 🤔

Warning: vkCreateInstance: Found no drivers!
Warning: vkCreateInstance failed with VK_ERROR_INCOMPATIBLE_DRIVER
    at CheckVkSuccessImpl (../../third_party/dawn/src/dawn/native/vulkan/VulkanError.cpp:101)

CleanShot 2024-05-15 at 16 13 07@2x CleanShot 2024-05-15 at 16 59 00@2x

digiwand avatar May 16 '24 00:05 digiwand

Builds ready [a50557f]
Page Load Metrics (1271 ± 582 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint6112488157
domContentLoaded9221131
load50291512711213582
domInteractive9221131
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 37 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

metamaskbot avatar May 24 '24 14:05 metamaskbot

Builds ready [22f1bea]
Page Load Metrics (1133 ± 564 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint691941153718
domContentLoaded96616157
load57273711331175564
domInteractive96516157
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 37 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

metamaskbot avatar May 27 '24 14:05 metamaskbot

Builds ready [7ea5ac6]
Page Load Metrics (805 ± 537 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint662071053316
domContentLoaded9211231
load5428278051118537
domInteractive9211231
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 37 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

metamaskbot avatar May 29 '24 07:05 metamaskbot

resolved a 1 line merge conflict f53b310acf5dc5fe79cfcdb3c2348f9e5b0e8d16. please rereview @pedronfigueiredo @matthewwalsh0 🙏🏼

digiwand avatar May 30 '24 12:05 digiwand

Builds ready [f53b310]
Page Load Metrics (305 ± 320 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint8011898126
domContentLoaded95317115
load672385305667320
domInteractive95317115
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 37 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

metamaskbot avatar May 30 '24 12:05 metamaskbot

resolved another minor merge conflict fe81382

digiwand avatar May 31 '24 06:05 digiwand

Builds ready [fe81382]
Page Load Metrics (112 ± 138 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint6811982105
domContentLoaded9131010
load411363112287138
domInteractive9131010

metamaskbot avatar May 31 '24 06:05 metamaskbot

Builds ready [f3fd7c8]
Page Load Metrics (68 ± 29 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint714181057335
domContentLoaded8117162311
load45325685929
domInteractive8117162311

metamaskbot avatar Jun 03 '24 09:06 metamaskbot

Builds ready [6e183cb]
Page Load Metrics (116 ± 136 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint70988384
domContentLoaded9221132
load421351116283136
domInteractive9221132

metamaskbot avatar Jun 03 '24 10:06 metamaskbot