metamask-extension icon indicating copy to clipboard operation
metamask-extension copied to clipboard

Version v11.17.0

Open benjisclowder opened this issue 1 year ago • 11 comments

Adding RC 11.17.0

benjisclowder avatar May 02 '24 12:05 benjisclowder

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] avatar May 02 '24 12:05 github-actions[bot]

Manual test scenarios:

Chrome

  • [ ] Onboarding - create a wallet
  • [ ] Onboarding - import a wallet
  • [ ] Keyring - connect hardware wallet
  • [ ] Keyring - reset a wallet
  • [ ] Transactions - send native token origin MM
  • [ ] Transactions - send native token origin dapp
  • [ ] Transactions - send ERC20 token origin MM
  • [ ] Transactions - send ERC20 token origin dapp
  • [ ] Transactions - send ERC721 token origin MM
  • [ ] Transactions - send ERC721 token origin dapp
  • [ ] Transactions - speed up transaction
  • [ ] Transactions - cancel transaction
  • [ ] Transactions - deploy failing transaction
  • [ ] Transactions - deposit and withdraw
  • [ ] Transactions - navigate multiple transactions
  • [ ] Transactions - send transactions with custom nonce
  • [ ] Transactions - cancel transaction using same nonce
  • [ ] Tokens - import ERC20 token origin MM
  • [ ] Tokens - import ERC20 token origin dapp
  • [ ] Tokens - import ERC721 token origin MM
  • [ ] Tokens - import ERC721 token origin dapp
  • [ ] Tokens - import ERC1155 token origin MM
  • [ ] Tokens - import ERC1155 token origin dapp
  • [ ] Tokens - approve ERC1155 token
  • [ ] Tokens - approve ERC20 token
  • [ ] Tokens - approve ERC721 token
  • [ ] Tokens - autodetect tokens
  • [ ] Tokens - autodetect NFTs
  • [ ] Tokens - approve erc20 custom amount
  • [ ] ENS - name resolution
  • [ ] Phishing - warning page
  • [ ] Network - add custom network manually
  • [ ] Network - add custom network from the list of popular networks
  • [ ] Network - add custom network from dApp
  • [ ] Network - update networks
  • [ ] Network - switching networks
  • [ ] Network - delete networks from the dropdown list
  • [ ] Network - delete networks in Settings
  • [ ] Backup - backup user data
  • [ ] Backup - restore user data
  • [ ] Metrics - send event metrics
  • [ ] Address-book - add a contact to the address book
  • [ ] Address-book - remove a contact from the address book
  • [ ] Address-book - update a contact in the address book
  • [ ] Gas fee - EIP-1559 gas
  • [ ] Gas fee - legacy gas
  • [ ] Sign - eth sign
  • [ ] Sign - personal sign
  • [ ] Sign - sign in with ethereum
  • [ ] Sign - sign typed with data
  • [ ] Sign - sign typed data v3 with hardware wallet
  • [ ] Sign - sign typed data v4 with hardware wallet
  • [ ] Sign - personal sign with hardware wallet
  • [ ] Sign - eth sign with hardware wallet
  • [ ] Permissions - connecting and disconnecting from a dapp
  • [ ] Swap - smart swap
  • [ ] Swap - swap eth
  • [ ] Incoming transactions - receive native token
  • [ ] Settings - about MetaMask
  • [ ] Settings - general - change language
  • [ ] Settings - advanced - check custom nonce toggle
  • [ ] Settings - advanced - show hex data
  • [ ] Contract - deploy contract, mint and import NFT with hardware wallet
  • [ ] Contract - hardware wallet qr based connect
  • [ ] Contract - send token with hardware wallet

Firefox

  • [ ] Onboarding - create a wallet
  • [ ] Onboarding - import a wallet
  • [ ] Keyring - connect hardware wallet
  • [ ] Keyring - reset a wallet
  • [ ] Transactions - send native token origin MM
  • [ ] Transactions - send native token origin dapp
  • [ ] Transactions - send ERC20 token origin MM
  • [ ] Transactions - send ERC20 token origin dapp
  • [ ] Transactions - send ERC721 token origin MM
  • [ ] Transactions - send ERC721 token origin dapp
  • [ ] Transactions - speed up transaction
  • [ ] Transactions - cancel transaction
  • [ ] Transactions - deploy failing transaction
  • [ ] Transactions - deposit and withdraw
  • [ ] Transactions - navigate multiple transactions
  • [ ] Transactions - send transactions with custom nonce
  • [ ] Transactions - cancel transaction using same nonce
  • [ ] Tokens - import ERC20 token origin MM
  • [ ] Tokens - import ERC20 token origin dapp
  • [ ] Tokens - import ERC721 token origin MM
  • [ ] Tokens - import ERC721 token origin dapp
  • [ ] Tokens - import ERC1155 token origin MM
  • [ ] Tokens - import ERC1155 token origin dapp
  • [ ] Tokens - approve ERC1155 token
  • [ ] Tokens - approve ERC20 token
  • [ ] Tokens - approve ERC721 token
  • [ ] Tokens - autodetect tokens
  • [ ] Tokens - autodetect NFTs
  • [ ] Tokens - approve erc20 custom amount
  • [ ] ENS - name resolution
  • [ ] Phishing - warning page
  • [ ] Network - add custom network manually
  • [ ] Network - add custom network from the list of popular networks
  • [ ] Network - add custom network from dApp
  • [ ] Network - update networks
  • [ ] Network - switching networks
  • [ ] Network - delete networks from the dropdown list
  • [ ] Network - delete networks in Settings
  • [ ] Backup - backup user data
  • [ ] Backup - restore user data
  • [ ] Metrics - send event metrics
  • [ ] Address-book - add a contact to the address book
  • [ ] Address-book - remove a contact from the address book
  • [ ] Address-book - update a contact in the address book
  • [ ] Gas fee - EIP-1559 gas
  • [ ] Gas fee - legacy gas
  • [ ] Sign - eth sign
  • [ ] Sign - personal sign
  • [ ] Sign - sign in with ethereum
  • [ ] Sign - sign typed with data
  • [ ] Sign - sign typed data v3 with hardware wallet
  • [ ] Sign - sign typed data v4 with hardware wallet
  • [ ] Sign - personal sign with hardware wallet
  • [ ] Sign - eth sign with hardware wallet
  • [ ] Permissions - connecting and disconnecting from a dapp
  • [ ] Swap - smart swap
  • [ ] Swap - swap eth
  • [ ] Incoming transactions - receive native token
  • [ ] Settings - about MetaMask
  • [ ] Settings - general - change language
  • [ ] Settings - advanced - check custom nonce toggle
  • [ ] Settings - advanced - show hex data
  • [ ] Contract - deploy contract, mint and import NFT with hardware wallet
  • [ ] Contract - hardware wallet qr based connect
  • [ ] Contract - send token with hardware wallet

benjisclowder avatar May 02 '24 13:05 benjisclowder

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@contentful/[email protected] None 0 133 kB whydah-gally
npm/@contentful/[email protected] None 0 146 kB whydah-gally
npm/@firebase/[email protected] None 0 67 kB google-wombot
npm/@firebase/[email protected] None 0 21.2 kB google-wombot
npm/@firebase/[email protected] network 0 680 kB google-wombot
npm/@firebase/[email protected] None 0 55.3 kB google-wombot
npm/@firebase/[email protected] None 0 2.9 kB google-wombot
npm/@firebase/[email protected] None 0 5.34 kB google-wombot
npm/@firebase/[email protected] network 0 664 kB google-wombot
npm/@firebase/[email protected] None 0 260 kB google-wombot
npm/@firebase/[email protected] None 0 9.56 kB google-wombot
npm/@firebase/[email protected] None 0 537 kB google-wombot
npm/@firebase/[email protected] None 0 1.66 MB google-wombot
npm/@firebase/[email protected] None 0 1.97 kB google-wombot
npm/@firebase/[email protected] None 0 15.5 kB google-wombot
npm/@firebase/[email protected] network 0 18 MB google-wombot
npm/@firebase/[email protected] None 0 177 kB google-wombot
npm/@firebase/[email protected] None 0 2.57 MB google-wombot
npm/@firebase/[email protected] None 0 6.26 kB google-wombot
npm/@firebase/[email protected] environment 0 10.6 MB google-wombot
npm/@firebase/[email protected] None 0 835 kB google-wombot
npm/@firebase/[email protected] None 0 13.6 kB google-wombot
npm/@firebase/[email protected] None 0 33.4 MB google-wombot
npm/@firebase/[email protected] None 0 75.2 kB google-wombot
npm/@firebase/[email protected] None 0 6.15 kB google-wombot
npm/@firebase/[email protected] network 0 430 kB google-wombot
npm/@firebase/[email protected] None 0 34.6 kB google-wombot
npm/@firebase/[email protected] None 0 2.34 kB google-wombot
npm/@firebase/[email protected] network 0 506 kB google-wombot
npm/@firebase/[email protected] None 0 85.9 kB google-wombot
npm/@firebase/[email protected] None 0 57.4 kB google-wombot
npm/@firebase/[email protected] None 0 1.87 kB google-wombot
npm/@firebase/[email protected] network 0 1 MB google-wombot
npm/@firebase/[email protected] None 0 37.1 kB google-wombot
npm/@firebase/[email protected] None 0 4.56 kB google-wombot
npm/@firebase/[email protected] network 0 615 kB google-wombot
npm/@firebase/[email protected] None 0 54.4 kB google-wombot
npm/@firebase/[email protected] None 0 5.93 kB google-wombot
npm/@firebase/[email protected] network 0 535 kB google-wombot
npm/@firebase/[email protected] None 0 185 kB google-wombot
npm/@firebase/[email protected] None 0 6.41 kB google-wombot
npm/@firebase/[email protected] None 0 2.64 MB google-wombot
npm/@firebase/[email protected] environment 0 1.14 MB google-wombot
npm/@firebase/[email protected] None 0 3.72 MB google-wombot
npm/@grpc/[email protected] environment, filesystem, network 0 1.68 MB murgatroid99
npm/@grpc/[email protected] filesystem 0 120 kB murgatroid99
npm/@metamask/[email protected] None 0 77.4 kB metamaskbot
npm/@metamask/[email protected] None 0 40.1 kB metamaskbot
npm/@metamask/[email protected] None +2 660 kB metamaskbot
npm/@metamask/[email protected] None +1 192 kB metamaskbot
npm/@metamask/[email protected] None +1 187 kB metamaskbot
npm/@metamask/[email protected] network +14 5.15 MB metamaskbot
npm/@metamask/[email protected] None 0 1.26 MB metamaskbot
npm/@metamask/[email protected] None 0 5.48 MB metamaskbot
npm/@metamask/[email protected] None 0 879 kB metamaskbot
npm/@metamask/[email protected] network 0 1.64 MB metamaskbot
npm/@metamask/[email protected] network +15 4.74 MB metamaskbot
npm/@noble/[email protected] None 0 622 kB paulmillr
npm/[email protected] None 0 27.4 kB bpierre
npm/[email protected] None 0 20.1 kB whydah-gally
npm/[email protected] None 0 66.2 kB contentful-ecosystem
npm/[email protected] environment, eval, filesystem, network +1 5.34 MB contentful-ecosystem
npm/[email protected] None 0 119 kB planttheidea
npm/[email protected] network 0 30.8 kB jcoglan
npm/[email protected] None 0 27.2 MB google-wombot
npm/[email protected] None 0 90.3 kB jaffathecake
npm/[email protected] None 0 6.58 kB keik
npm/[email protected] None 0 8.38 kB sindresorhus
npm/[email protected] None 0 4.92 kB lgbot
npm/[email protected] None 0 674 kB colinmcd94

🚮 Removed packages: npm/@metamask/[email protected], npm/@metamask/[email protected], npm/@metamask/[email protected], npm/@metamask/[email protected], npm/@metamask/[email protected], npm/@metamask/[email protected], npm/@metamask/[email protected], npm/@metamask/[email protected], npm/@metamask/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

socket-security[bot] avatar May 02 '24 13:05 socket-security[bot]

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSource
Network access npm/@grpc/[email protected]
Network access npm/@grpc/[email protected]
Network access npm/@grpc/[email protected]
Network access npm/@grpc/[email protected]
Network access npm/@grpc/[email protected]
Network access npm/@firebase/[email protected]
Network access npm/@firebase/[email protected]
Network access npm/@firebase/[email protected]
Network access npm/@firebase/[email protected]
Network access npm/@firebase/[email protected]
Network access npm/@firebase/[email protected]
Network access npm/@firebase/[email protected]
Network access npm/@firebase/[email protected]
Network access npm/@firebase/[email protected]
Network access npm/[email protected]
Network access npm/[email protected]

View full report↗︎

Next steps

What is network access?

This module accesses the network.

Packages should remove all network access that is functionally unnecessary. Consumers should audit network access to ensure legitimate use.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

socket-security[bot] avatar May 02 '24 13:05 socket-security[bot]

Reopening next week on Thursday.

benjisclowder avatar May 02 '24 13:05 benjisclowder

Builds ready [ad346f4]
Page Load Metrics (887 ± 541 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint6213087178
domContentLoaded86213115
load5126298871126541
domInteractive86213115
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

metamaskbot avatar May 10 '24 22:05 metamaskbot

Manual test scenarios:

Chrome

  • [x] Onboarding - create a wallet
  • [x] Onboarding - import a wallet
  • [x] Keyring - connect hardware wallet
  • [x] Keyring - reset a wallet
  • [x] Transactions - send native token origin MM
  • [x] Transactions - send native token origin dapp
  • [x] Transactions - send ERC20 token origin MM
  • [x] Transactions - send ERC20 token origin dapp
  • [x] Transactions - send ERC721 token origin MM
  • [x] Transactions - send ERC721 token origin dapp
  • [x] Transactions - speed up transaction
  • [x] Transactions - cancel transaction
  • [x] Transactions - deploy failing transaction
  • [x] Transactions - deposit and withdraw
  • [x] Transactions - navigate multiple transactions
  • [x] Transactions - send transactions with custom nonce
  • [x] Transactions - cancel transaction using same nonce
  • [x] Tokens - import ERC20 token origin MM
  • [x] Tokens - import ERC20 token origin dapp
  • [x] Tokens - import ERC721 token origin MM
  • [x] Tokens - import ERC721 token origin dapp
  • [x] Tokens - import ERC1155 token origin MM
  • [x] Tokens - import ERC1155 token origin dapp
  • [x] Tokens - approve ERC1155 token
  • [x] Tokens - approve ERC20 token
  • [x] Tokens - approve ERC721 token
  • [x] Tokens - autodetect tokens
  • [x] Tokens - autodetect NFTs
  • [x] Tokens - approve erc20 custom amount
  • [x] ENS - name resolution
  • [x] Phishing - warning page
  • [x] Network - add custom network manually
  • [x] Network - add custom network from the list of popular networks
  • [x] Network - add custom network from dApp
  • [x] Network - update networks
  • [x] Network - switching networks
  • [x] Network - delete networks from the dropdown list
  • [x] Network - delete networks in Settings
  • [x] Backup - backup user data
  • [x] Backup - restore user data
  • [x] Metrics - send event metrics
  • [x] Address-book - add a contact to the address book
  • [x] Address-book - remove a contact from the address book
  • [x] Address-book - update a contact in the address book
  • [x] Gas fee - EIP-1559 gas
  • [x] Gas fee - legacy gas
  • [x] Sign - eth sign
  • [x] Sign - personal sign
  • [x] Sign - sign in with ethereum
  • [x] Sign - sign typed with data
  • [x] Sign - sign typed data v3 with hardware wallet
  • [x] Sign - sign typed data v4 with hardware wallet
  • [x] Sign - personal sign with hardware wallet
  • [x] Sign - eth sign with hardware wallet
  • [x] Permissions - connecting and disconnecting from a dapp
  • [x] Swap - smart swap
  • [x] Swap - swap eth
  • [x] Incoming transactions - receive native token
  • [x] Settings - about MetaMask
  • [x] Settings - general - change language
  • [x] Settings - advanced - check custom nonce toggle
  • [x] Settings - advanced - show hex data
  • [x] Contract - deploy contract, mint and import NFT with hardware wallet
  • [x] Contract - hardware wallet qr based connect
  • [x] Contract - send token with hardware wallet

Firefox

  • [x] Onboarding - create a wallet
  • [x] Onboarding - import a wallet
  • [x] Keyring - connect hardware wallet
  • [x] Keyring - reset a wallet
  • [x] Transactions - send native token origin MM
  • [x] Transactions - send native token origin dapp
  • [x] Transactions - send ERC20 token origin MM
  • [x] Transactions - send ERC20 token origin dapp
  • [x] Transactions - send ERC721 token origin MM
  • [x] Transactions - send ERC721 token origin dapp
  • [x] Transactions - speed up transaction
  • [x] Transactions - cancel transaction
  • [x] Transactions - deploy failing transaction
  • [x] Transactions - deposit and withdraw
  • [x] Transactions - navigate multiple transactions
  • [x] Transactions - send transactions with custom nonce
  • [x] Transactions - cancel transaction using same nonce
  • [x] Tokens - import ERC20 token origin MM
  • [x] Tokens - import ERC20 token origin dapp
  • [x] Tokens - import ERC721 token origin MM
  • [x] Tokens - import ERC721 token origin dapp
  • [x] Tokens - import ERC1155 token origin MM
  • [x] Tokens - import ERC1155 token origin dapp
  • [x] Tokens - approve ERC1155 token
  • [x] Tokens - approve ERC20 token
  • [x] Tokens - approve ERC721 token
  • [x] Tokens - autodetect tokens
  • [x] Tokens - autodetect NFTs
  • [x] Tokens - approve erc20 custom amount
  • [x] ENS - name resolution
  • [x] Phishing - warning page
  • [x] Network - add custom network manually
  • [x] Network - add custom network from the list of popular networks
  • [x] Network - add custom network from dApp
  • [x] Network - update networks
  • [x] Network - switching networks
  • [x] Network - delete networks from the dropdown list
  • [x] Network - delete networks in Settings
  • [x] Backup - backup user data
  • [x] Backup - restore user data
  • [x] Metrics - send event metrics
  • [x] Address-book - add a contact to the address book
  • [x] Address-book - remove a contact from the address book
  • [x] Address-book - update a contact in the address book
  • [x] Gas fee - EIP-1559 gas
  • [x] Gas fee - legacy gas
  • [x] Sign - eth sign
  • [x] Sign - personal sign
  • [x] Sign - sign in with ethereum
  • [x] Sign - sign typed with data
  • [x] Sign - sign typed data v3 with hardware wallet
  • [x] Sign - sign typed data v4 with hardware wallet
  • [x] Sign - personal sign with hardware wallet
  • [x] Sign - eth sign with hardware wallet
  • [x] Permissions - connecting and disconnecting from a dapp
  • [x] Swap - smart swap
  • [x] Swap - swap eth
  • [x] Incoming transactions - receive native token
  • [x] Settings - about MetaMask
  • [x] Settings - general - change language
  • [x] Settings - advanced - check custom nonce toggle
  • [x] Settings - advanced - show hex data
  • [x] Contract - deploy contract, mint and import NFT with hardware wallet
  • [x] Contract - hardware wallet qr based connect
  • [x] Contract - send token with hardware wallet

benjisclowder avatar May 11 '24 09:05 benjisclowder

We need teams' approval by May 22.

Instructions for Team Review

Review Changes: Refer to the Release Tracker for v11.17.0 to see all changes relevant to your team.

Log Bugs: If you find any issues, log them in the release tracker and attach them to https://github.com/MetaMask/MetaMask-planning/issues/2467.

Approval: After reviewing, indicate your team's approval by:

  • Marking the checkbox next to your team's name in this comment.
  • Optionally, leave a comment for additional information.

Your thorough review ensures a smooth and successful release. If you have any questions please reach out to extension platform team or in the #metamask-qa slack channel. Thank you for your collaboration!

  • [x] Accounts: @gantunesr - There are 2 Accounts changes in v11.17.0
  • [x] Assets: @sahar-fehri / @alfeng6 - There are 4 Assets changes in v11.17.0
  • [x] Confirmations: @sleepytanya - There are 30 Confirmation Systems changes in v11.17.0.
  • [ ] DappAPI: @jiexi - There are 2 DappAPI changes in v11.17.0.
  • [x] Design/Systems: @georgewrmarshall - There are 3 Design/Systems change in v11.17.0.
  • [ ] Devex: @tmashuang / @vandan - There are 3 Devex changes in v11.17.0.
  • [x] MMI: @zone-live / @shane-t - There are 4 MMI changes in v11.17.0.
  • [ ] Shared Libraries: @Gudahtt - There are 4 Shared Libraries changes in v11.17.0.
  • [x] Snaps: @bowensanders / @FrederikBolding / @Montoya - There are 6 Snaps changes in v11.17.0.
  • [ ] Swaps: @davibroc / @dan437 - There are 2 Swaps change in v11.17.0.
  • [x] Wallet UX: @darkwing / @NidhiKJha - There are 12 Wallet UX changes in v11.17.0.

benjisclowder avatar May 14 '24 13:05 benjisclowder

Builds ready [ae3a260]
Page Load Metrics (1032 ± 569 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint721711013014
domContentLoaded106721157
load59267010321185569
domInteractive106721157
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 30 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

metamaskbot avatar May 20 '24 11:05 metamaskbot

Builds ready [bd5f6ca]
Page Load Metrics (690 ± 457 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint65145892412
domContentLoaded94716126
load532273690953457
domInteractive94716126
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 420 Bytes (0.01%)
  • ui: 35 Bytes (0.00%)
  • common: 89 Bytes (0.00%)

metamaskbot avatar May 20 '24 18:05 metamaskbot

Builds ready [7d4dcd4]
Page Load Metrics (1804 ± 558 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint691911204019
domContentLoaded9371674
load49295818041162558
domInteractive9371674
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 420 Bytes (0.01%)
  • ui: 35 Bytes (0.00%)
  • common: 89 Bytes (0.00%)

metamaskbot avatar May 21 '24 12:05 metamaskbot

Closing this PR as 11.17.0 was included in 12.0.0.

benjisclowder avatar Jul 21 '24 10:07 benjisclowder