metamask-extension icon indicating copy to clipboard operation
metamask-extension copied to clipboard

fix: Mantle token mispriced

Open bergeron opened this issue 10 months ago • 4 comments

Description

Patches https://github.com/MetaMask/core/pull/4045, fixing an issue where Mantle's native currency is mispriced.

Open in GitHub Codespaces

Related issues

Manual testing steps

Screenshots/Recordings

Before

Screenshot 2024-05-01 at 5 33 59 PM

After

Screenshot 2024-05-01 at 5 32 42 PM

Pre-merge author checklist

  • [ ] I’ve followed MetaMask Coding Standards.
  • [ ] I've completed the PR template to the best of my ability
  • [ ] I’ve included tests if applicable
  • [ ] I’ve documented my code using JSDoc format if applicable
  • [ ] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

bergeron avatar May 02 '24 00:05 bergeron

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] avatar May 02 '24 00:05 github-actions[bot]

you have to use conventional commit

salimtb avatar May 02 '24 10:05 salimtb

LGTM! 🙏

sahar-fehri avatar May 02 '24 12:05 sahar-fehri

Builds ready [c8bd4e1]
Page Load Metrics (1199 ± 678 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint6212995199
domContentLoaded97116136
load49363011991412678
domInteractive97116136
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 49 Bytes (0.00%)

metamaskbot avatar May 07 '24 09:05 metamaskbot