metamask-extension icon indicating copy to clipboard operation
metamask-extension copied to clipboard

Published 20 hours ago • verified publisher icon MetaMask

feat: percentage increase feature

Open salimtb opened this issue 10 months ago • 6 comments

Description

This pull request introduces a new feature to the MetaMask extension that enhances user experience by displaying the percentage increase or decrease for each token directly within the UI. This update aims to provide users with immediate visual feedback on the performance of their tokens, helping them make more informed decisions based on recent market trends.

core PR: https://github.com/MetaMask/core/pull/4206

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to the wallet view
  2. You should see the percentage of increase/decrease

Screenshots/Recordings

Before

Screenshot 2024-04-24 at 15 03 39

After

Screenshot 2024-04-24 at 14 53 25

Pre-merge author checklist

  • [x] I’ve followed MetaMask Coding Standards.
  • [x] I've completed the PR template to the best of my ability
  • [x] I’ve included tests if applicable
  • [x] I’ve documented my code using JSDoc format if applicable
  • [x] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

salimtb avatar Apr 24 '24 13:04 salimtb

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] avatar Apr 24 '24 13:04 github-actions[bot]

Builds ready [0e141e0]
Page Load Metrics (842 ± 578 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint57162862813
domContentLoaded8331253
load4529508421203578
domInteractive8331253
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 3.7 KiB (0.06%)
  • common: 95 Bytes (0.00%)

metamaskbot avatar Apr 26 '24 10:04 metamaskbot

Codecov Report

Attention: Patch coverage is 95.58824% with 3 lines in your changes missing coverage. Please review.

Project coverage is 65.42%. Comparing base (2115516) to head (6035cce). Report is 16 commits behind head on develop.

Files Patch % Lines
...and-amount-change/percentage-and-amount-change.tsx 94.44% 2 Missing :warning:
app/scripts/lib/util.ts 90.91% 1 Missing :warning:
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop   #24223      +/-   ##
===========================================
+ Coverage    65.39%   65.42%   +0.04%     
===========================================
  Files         1382     1384       +2     
  Lines        54764    54830      +66     
  Branches     14369    14391      +22     
===========================================
+ Hits         35809    35872      +63     
- Misses       18955    18958       +3

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Apr 26 '24 13:04 codecov[bot]

Builds ready [c1cf600]
Page Load Metrics (759 ± 571 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint61194983718
domContentLoaded106816136
load4929197591188571
domInteractive106816136
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 3.8 KiB (0.06%)
  • common: 53 Bytes (0.00%)

metamaskbot avatar May 02 '24 11:05 metamaskbot

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher

🚮 Removed packages: npm/[email protected], npm/[email protected]

View full report↗︎

socket-security[bot] avatar May 14 '24 10:05 socket-security[bot]

No dependency changes detected. Learn more about Socket for GitHub ↗︎

👍 No dependency changes detected in pull request

socket-security[bot] avatar May 16 '24 07:05 socket-security[bot]

Builds ready [59e5fc1]
Page Load Metrics (109 ± 135 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint6314181178
domContentLoaded811910
load381335109281135
domInteractive811910
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 6.25 KiB (0.09%)
  • common: 0 Bytes (0.00%)

metamaskbot avatar Jun 14 '24 23:06 metamaskbot

Builds ready [7163e90]
Page Load Metrics (48 ± 4 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint64927874
domContentLoaded9231242
load40644884
domInteractive9231242
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 6.5 KiB (0.09%)
  • common: 77 Bytes (0.00%)

metamaskbot avatar Jun 19 '24 15:06 metamaskbot

Builds ready [6035cce]
Page Load Metrics (53 ± 6 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint7212186105
domContentLoaded10171221
load4110453136
domInteractive10171121
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 6.49 KiB (0.09%)
  • common: 195 Bytes (0.00%)

metamaskbot avatar Jun 20 '24 16:06 metamaskbot

nice feature code LGTM

EtherWizard33 avatar Jun 21 '24 09:06 EtherWizard33