metamask-extension icon indicating copy to clipboard operation
metamask-extension copied to clipboard

feat: New onboarding text

Open jonybur opened this issue 10 months ago • 4 comments

Description

Updates the "Help us improve MetaMask" copy during onboarding.

Open in GitHub Codespaces

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/2336

Manual testing steps

  1. Start onboarding
  2. Check that the copy in the 'Help us improve MetaMask' screen matches the new copy.
  3. Test the Privacy Policy link

Screenshots/Recordings

Before

Screenshot 2024-04-16 at 12 25 09

After

Screenshot 2024-05-05 at 01 52 00

Pre-merge author checklist

  • [ ] I’ve followed MetaMask Coding Standards.
  • [ ] I've completed the PR template to the best of my ability
  • [ ] I’ve included tests if applicable
  • [ ] I’ve documented my code using JSDoc format if applicable
  • [ ] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

jonybur avatar Apr 16 '24 11:04 jonybur

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] avatar Apr 16 '24 11:04 github-actions[bot]

Except for test-unit-jest-main (which should become green after the above-suggested changes), other failures seem unrelated to this PR

mikesposito avatar May 10 '24 10:05 mikesposito

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 67.43%. Comparing base (d27a233) to head (941467f). Report is 59 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #24050      +/-   ##
===========================================
+ Coverage    67.37%   67.43%   +0.06%     
===========================================
  Files         1278     1289      +11     
  Lines        49881    50249     +368     
  Branches     12944    13027      +83     
===========================================
+ Hits         33605    33883     +278     
- Misses       16276    16366      +90     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 10 '24 19:05 codecov[bot]

Builds ready [a7cb32d]
Page Load Metrics (452 ± 441 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint66168872612
domContentLoaded95116126
load542765452918441
domInteractive95116126
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 3.18 KiB (0.05%)
  • common: 1.51 KiB (0.02%)

metamaskbot avatar May 10 '24 19:05 metamaskbot

Builds ready [adcdba8]
Page Load Metrics (1544 ± 787 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint732021174421
domContentLoaded10441784
load59387915441639787
domInteractive10441784
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 2.81 KiB (0.04%)
  • common: 1.51 KiB (0.02%)

metamaskbot avatar May 14 '24 21:05 metamaskbot