[Bug]: Clicking on false positive, Blockaid link does not add external_link_clicked to signature events
Describe the bug
Clicking to report a false positive security alerts triggers doesn't add external_link_clicked to the respective signature event. Only no-signature transactions.
Related to: https://github.com/MetaMask/MetaMask-planning/issues/1756 Discovered: https://github.com/MetaMask/metamask-extension/issues/23555#issuecomment-2050547846 Example metric
Expected behavior
Clicking to report a false positive security alerts triggers doesn't add external_link_clicked to the respective transaction and signature events
Screenshots/Recordings
No response
Steps to reproduce
- Turn on Blockaid in Security Settings
- Go to test dapp
- Test PPOM buttons
- Observe reports
Error messages or log output
No response
Version
11.13.0
Build type
None
Browser
Chrome
Operating system
Windows
Hardware wallet
No response
Additional context
No response
Severity
No response
This issue has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 45 days if there is no further activity. The MetaMask team intends on reviewing this issue before close, and removing the stale label if it is still a bug. We welcome new comments on this issue. We do not intend on closing issues if they report bugs that are still reproducible. Thank you for your contributions.
This issue will be much easier to address once this PR is merged https://github.com/MetaMask/metamask-extension/pull/27043
This issue has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 45 days if there is no further activity. The MetaMask team intends on reviewing this issue before close, and removing the stale label if it is still a bug. We welcome new comments on this issue. We do not intend on closing issues if they report bugs that are still reproducible. Thank you for your contributions.