metamask-extension
metamask-extension copied to clipboard
[Bug]: User is able to send and (possibly) confirm transactions that involve 0 NFTs (ERC1155)
Describe the bug
You can send and confirm transactions that involve 0 NFTs (I haven't tried to confirm the transaction but 'Confirm' button is active). In such transactions, the 'Total' field will display the NFT's name along with applicable fees. The 'Estimated changes' field does not display the NFT's name. Current Send flow doesn't let user send 0 NFT.
Expected behavior
Screenshots/Recordings
Multichain:
https://github.com/MetaMask/metamask-extension/assets/104780023/2d26cdfb-4a96-4fe8-a36c-160001b19ebb
NFT Send flow on production:
https://github.com/MetaMask/metamask-extension/assets/104780023/151d9552-f2ac-450b-a6fd-69e68903c665
Steps to reproduce
- Go to NFT tab.
- Click on any NFT to start Send transaction
- Choose the recipient's address
- You can send 0 NFT
Error messages or log output
No response
Version
Dev build develop branch
Build type
None
Browser
Chrome
Operating system
MacOS
Hardware wallet
No response
Additional context
No response
Severity
No response
Dev build mb843/data-flows
, Chrome
Still able to send 0 NFT:
https://github.com/MetaMask/metamask-extension/assets/104780023/d7754c99-0166-470e-b38f-d7ba3ca82ee1
Still present on the latest build:
https://github.com/MetaMask/metamask-extension/assets/104780023/a2f245db-7a95-40fd-be78-8771dedd87ec
This looks like it's by design. When transferring tokens a user is allowed to transfer 0 if they so desire. However, I agree though that his could be confusing from an ERC1155 perspective.
Comparing V11.13.1 to develop, this looks to be a regression.
No longer present on latest swap+send build; removing tag
https://github.com/MetaMask/metamask-extension/assets/44588480/f4c711ee-acab-4471-9b26-e52087b07df6
For hygiene, does this mean we can close this ticket once Swap and Send is merged?
Fixed - user can't send 0 NFT:
https://github.com/MetaMask/metamask-extension/assets/104780023/c146c113-74df-46ec-aa27-c48b669694d2
Present on RC 11.17.0
https://jam.dev/c/9348ba95-208a-4545-903d-6fd16831df1c
and on production 11.15.4
https://jam.dev/c/db00270a-fa7c-4d35-93d8-febf89547952
This issue has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 45 days if there is no further activity. The MetaMask team intends on reviewing this issue before close, and removing the stale label if it is still a bug. We welcome new comments on this issue. We do not intend on closing issues if they report bugs that are still reproducible. Thank you for your contributions.
Hey I created the USDT USDA and the usdc I was at the Clark house apartments when I was in the ftx hackathon. So I not going to steal . Do your homework before you excuse