metamask-extension icon indicating copy to clipboard operation
metamask-extension copied to clipboard
verified publisher icon MetaMask

feat: add multiple alert modal to `AlertRow` component

Open vinistevam opened this issue 2 years ago • 5 comments

Description

The PR aims to update the alert logic within the AlertRow component to include the multiple alert modal component and show it when the inline alert is clicked.

Open in GitHub Codespaces

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/2291

Manual testing steps

Screenshots/Recordings

alert-row.webm

Before

After

Pre-merge author checklist

  • [x] I’ve followed MetaMask Coding Standards.
  • [x] I've completed the PR template to the best of my ability
  • [x] I’ve included tests if applicable
  • [x] I’ve documented my code using JSDoc format if applicable
  • [x] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

vinistevam avatar Mar 27 '24 13:03 vinistevam

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] avatar Mar 27 '24 13:03 github-actions[bot]

Builds ready [1e18ebd]
Page Load Metrics (464 ± 366 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint61160982512
domContentLoaded95724157
load492124464762366
domInteractive95724157
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 15.81 KiB (0.22%)
  • common: 158 Bytes (0.00%)

metamaskbot avatar Apr 10 '24 11:04 metamaskbot

Builds ready [3179c6a]
Page Load Metrics (1322 ± 546 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint613821529244
domContentLoaded89027199
load49273113221137546
domInteractive89027199
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 15.62 KiB (0.22%)
  • common: 158 Bytes (0.00%)

metamaskbot avatar Apr 12 '24 10:04 metamaskbot

Builds ready [d61eb85]
Page Load Metrics (999 ± 613 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint681901113818
domContentLoaded108227189
load5433669991277613
domInteractive108227189
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 17.75 KiB (0.28%)
  • common: 158 Bytes (0.00%)

metamaskbot avatar Apr 23 '24 06:04 metamaskbot

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 67.66%. Comparing base (91aefe6) to head (d61eb85).

:exclamation: Current head d61eb85 differs from pull request most recent head 45add14. Consider uploading reports for the commit 45add14 to get more accurate results

Additional details and impacted files 
@@                             Coverage Diff                              @@
##           feat/add-inline-alert-info-row-component   #23759      +/-   ##
============================================================================
+ Coverage                                     67.31%   67.66%   +0.34%     
============================================================================
  Files                                          1277     1259      -18     
  Lines                                         49771    49229     -542     
  Branches                                      12937    12844      -93     
============================================================================
- Hits                                          33503    33306     -197     
+ Misses                                        16268    15923     -345

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Apr 23 '24 06:04 codecov[bot]

Builds ready [e5f07e3]
Page Load Metrics (646 ± 562 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint6812783157
domContentLoaded9271252
load5633836461171562
domInteractive9271252
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 29 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

metamaskbot avatar May 09 '24 09:05 metamaskbot

Builds ready [3a6f438]
Page Load Metrics (205 ± 288 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint6810582105
domContentLoaded9371363
load552824205601288
domInteractive9371363
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

metamaskbot avatar May 10 '24 10:05 metamaskbot

Missing release label release-11.17.0 on PR. Adding release label release-11.17.0 on PR and removing other release labels(release-11.18.0), as PR was added to branch 11.17.0 when release was cut.

metamaskbot avatar May 23 '24 23:05 metamaskbot