metamask-extension icon indicating copy to clipboard operation
metamask-extension copied to clipboard

Published 20 hours ago • verified publisher icon MetaMask

feat: adding styles to blockaid banner spinner

Open jpuri opened this issue 6 months ago • 1 comments

Description

Style the spinner on blockaid banner.

Related issues

Fixes: MetaMask/metamask-extension#22842

Manual testing steps

  1. Go to test DAPP
  2. Submit malicious transaction
  3. Check spinner appearing in transaction page

Screenshots/Recordings

Screenshot 2024-02-19 at 12 26 17 PM

Screenshot 2024-02-19 at 12 24 57 PM

Pre-merge author checklist

  • [X] I’ve followed MetaMask Coding Standards.
  • [X] I've clearly explained what problem this PR is solving and how it is solved.
  • [X] I've linked related issues
  • [X] I've included manual testing steps
  • [X] I've included screenshots/recordings if applicable
  • [X] I’ve included tests if applicable
  • [ ] I’ve documented my code using JSDoc format if applicable
  • [X] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • [X] I’ve properly set the pull request status:
    • [ ] In case it's not yet "ready for review", I've set it to "draft".
    • [X] In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

jpuri avatar Feb 19 '24 07:02 jpuri

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] avatar Feb 19 '24 07:02 github-actions[bot]

Builds ready [d35fa0c]
Page Load Metrics (893 ± 32 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1243871945526
domContentLoaded1392322713
load81811068936632
domInteractive1392322713
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 998 Bytes (0.01%)
  • common: 109 Bytes (0.00%)

metamaskbot avatar Feb 19 '24 08:02 metamaskbot

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (afb1b66) 68.49% compared to head (ca47322) 68.49%. Report is 2 commits behind head on develop.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop   #23039      +/-   ##
===========================================
+ Coverage    68.49%   68.49%   +0.01%     
===========================================
  Files         1090     1090              
  Lines        43133    43139       +6     
  Branches     11501    11503       +2     
===========================================
+ Hits         29541    29548       +7     
+ Misses       13592    13591       -1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 19 '24 08:02 codecov[bot]

Builds ready [3a1e433]
Page Load Metrics (1856 ± 119 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1094041676632
domContentLoaded127831178
load151223441856248119
domInteractive127831178
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 1.3 KiB (0.02%)
  • common: 109 Bytes (0.00%)

metamaskbot avatar Feb 21 '24 07:02 metamaskbot

Builds ready [5cb021e]
Page Load Metrics (1728 ± 81 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint12374724116378
domContentLoaded98032199
load15032127172816981
domInteractive98032199
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 1.3 KiB (0.02%)
  • common: 109 Bytes (0.00%)

metamaskbot avatar Feb 22 '24 07:02 metamaskbot

Builds ready [ca47322]
Page Load Metrics (1875 ± 86 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint984061888842
domContentLoaded126129136
load16012210187518086
domInteractive126129136
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 1.3 KiB (0.02%)
  • common: 109 Bytes (0.00%)

metamaskbot avatar Feb 22 '24 10:02 metamaskbot

The PR has been put on hold as the designs are under review.

jpuri avatar Feb 22 '24 15:02 jpuri