metamask-extension
metamask-extension copied to clipboard
feat: adding styles to blockaid banner spinner
Description
Style the spinner on blockaid banner.
Related issues
Fixes: MetaMask/metamask-extension#22842
Manual testing steps
- Go to test DAPP
- Submit malicious transaction
- Check spinner appearing in transaction page
Screenshots/Recordings
Pre-merge author checklist
- [X] I’ve followed MetaMask Coding Standards.
- [X] I've clearly explained what problem this PR is solving and how it is solved.
- [X] I've linked related issues
- [X] I've included manual testing steps
- [X] I've included screenshots/recordings if applicable
- [X] I’ve included tests if applicable
- [ ] I’ve documented my code using JSDoc format if applicable
- [X] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
- [X] I’ve properly set the pull request status:
- [ ] In case it's not yet "ready for review", I've set it to "draft".
- [X] In case it's "ready for review", I've changed it from "draft" to "non-draft".
Pre-merge reviewer checklist
- [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.
Builds ready [d35fa0c]
- builds: chrome, firefox
- builds (beta): chrome
- builds (flask): chrome, firefox
- builds (MMI): chrome, firefox
- builds (test): chrome, firefox
- builds (test-flask): chrome, firefox
- build viz: Build System
- mv3: Background Module Init Stats
- mv3: UI Init Stats
- mv3: Module Load Stats
- mv3: Bundle Size Stats
- mv2: E2e Actions Stats
- code coverage: Report
- storybook: Storybook
- typescript migration: Dashboard
- all artifacts
Page Load Metrics (893 ± 32 ms)
Platform | Page | Metric | Min (ms) | Max (ms) | Average (ms) | StandardDeviation (ms) | MarginOfError (ms) |
---|---|---|---|---|---|---|---|
Chrome | Home | firstPaint | 124 | 387 | 194 | 55 | 26 |
domContentLoaded | 13 | 92 | 32 | 27 | 13 | ||
load | 818 | 1106 | 893 | 66 | 32 | ||
domInteractive | 13 | 92 | 32 | 27 | 13 |
Bundle size diffs [🚨 Warning! Bundle size has increased!]
- background: 0 Bytes (0.00%)
- ui: 998 Bytes (0.01%)
- common: 109 Bytes (0.00%)
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
afb1b66
) 68.49% compared to head (ca47322
) 68.49%. Report is 2 commits behind head on develop.
Additional details and impacted files
@@ Coverage Diff @@
## develop #23039 +/- ##
===========================================
+ Coverage 68.49% 68.49% +0.01%
===========================================
Files 1090 1090
Lines 43133 43139 +6
Branches 11501 11503 +2
===========================================
+ Hits 29541 29548 +7
+ Misses 13592 13591 -1
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Builds ready [3a1e433]
- builds: chrome, firefox
- builds (beta): chrome
- builds (flask): chrome, firefox
- builds (MMI): chrome, firefox
- builds (test): chrome, firefox
- builds (test-flask): chrome, firefox
- build viz: Build System
- mv3: Background Module Init Stats
- mv3: UI Init Stats
- mv3: Module Load Stats
- mv3: Bundle Size Stats
- mv2: E2e Actions Stats
- code coverage: Report
- storybook: Storybook
- typescript migration: Dashboard
- all artifacts
Page Load Metrics (1856 ± 119 ms)
Platform | Page | Metric | Min (ms) | Max (ms) | Average (ms) | StandardDeviation (ms) | MarginOfError (ms) |
---|---|---|---|---|---|---|---|
Chrome | Home | firstPaint | 109 | 404 | 167 | 66 | 32 |
domContentLoaded | 12 | 78 | 31 | 17 | 8 | ||
load | 1512 | 2344 | 1856 | 248 | 119 | ||
domInteractive | 12 | 78 | 31 | 17 | 8 |
Bundle size diffs [🚨 Warning! Bundle size has increased!]
- background: 0 Bytes (0.00%)
- ui: 1.3 KiB (0.02%)
- common: 109 Bytes (0.00%)
Builds ready [5cb021e]
- builds: chrome, firefox
- builds (beta): chrome
- builds (flask): chrome, firefox
- builds (MMI): chrome, firefox
- builds (test): chrome, firefox
- builds (test-flask): chrome, firefox
- build viz: Build System
- mv3: Background Module Init Stats
- mv3: UI Init Stats
- mv3: Module Load Stats
- mv3: Bundle Size Stats
- mv2: E2e Actions Stats
- code coverage: Report
- storybook: Storybook
- typescript migration: Dashboard
- all artifacts
Page Load Metrics (1728 ± 81 ms)
Platform | Page | Metric | Min (ms) | Max (ms) | Average (ms) | StandardDeviation (ms) | MarginOfError (ms) |
---|---|---|---|---|---|---|---|
Chrome | Home | firstPaint | 123 | 747 | 241 | 163 | 78 |
domContentLoaded | 9 | 80 | 32 | 19 | 9 | ||
load | 1503 | 2127 | 1728 | 169 | 81 | ||
domInteractive | 9 | 80 | 32 | 19 | 9 |
Bundle size diffs [🚨 Warning! Bundle size has increased!]
- background: 0 Bytes (0.00%)
- ui: 1.3 KiB (0.02%)
- common: 109 Bytes (0.00%)
Builds ready [ca47322]
- builds: chrome, firefox
- builds (beta): chrome
- builds (flask): chrome, firefox
- builds (MMI): chrome, firefox
- builds (test): chrome, firefox
- builds (test-flask): chrome, firefox
- build viz: Build System
- mv3: Background Module Init Stats
- mv3: UI Init Stats
- mv3: Module Load Stats
- mv3: Bundle Size Stats
- mv2: E2e Actions Stats
- code coverage: Report
- storybook: Storybook
- typescript migration: Dashboard
- all artifacts
Page Load Metrics (1875 ± 86 ms)
Platform | Page | Metric | Min (ms) | Max (ms) | Average (ms) | StandardDeviation (ms) | MarginOfError (ms) |
---|---|---|---|---|---|---|---|
Chrome | Home | firstPaint | 98 | 406 | 188 | 88 | 42 |
domContentLoaded | 12 | 61 | 29 | 13 | 6 | ||
load | 1601 | 2210 | 1875 | 180 | 86 | ||
domInteractive | 12 | 61 | 29 | 13 | 6 |
Bundle size diffs [🚨 Warning! Bundle size has increased!]
- background: 0 Bytes (0.00%)
- ui: 1.3 KiB (0.02%)
- common: 109 Bytes (0.00%)
The PR has been put on hold as the designs are under review.