metamask-extension icon indicating copy to clipboard operation
metamask-extension copied to clipboard
verified publisher icon MetaMask

Bump test dapp to v8.1.0

Open tmashuang opened this issue 1 year ago • 2 comments

Description

Bumps test-dapp to v8.1.0 which includes changes to PPOM, wallet_revokePermissions, and signing. https://github.com/MetaMask/test-dapp/compare/v7.3.1...v8.1.0

This adjusts the messages that the blockaid warnings on the confirmation screens, but is not indicative of what happens in prod. The other way would be to remove the mockInfuraWithMaliciousResponses, which is giving a warning rather than a danger message, and represents the proper message that is shown in prod.

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • [x] I’ve followed MetaMask Coding Standards.
  • [x] I've clearly explained what problem this PR is solving and how it is solved.
  • [x] I've linked related issues
  • [x] I've included manual testing steps
  • [x] I've included screenshots/recordings if applicable
  • [x] I’ve included tests if applicable
  • [x] I’ve documented my code using JSDoc format if applicable
  • [x] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • [x] I’ve properly set the pull request status:
    • [x] In case it's not yet "ready for review", I've set it to "draft".
    • [x] In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

tmashuang avatar Feb 16 '24 22:02 tmashuang

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] avatar Feb 16 '24 22:02 github-actions[bot]

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/[email protected] None 0 12.4 MB gudahtt

🚮 Removed packages: npm/@metamask/[email protected]

View full report↗︎

socket-security[bot] avatar Feb 16 '24 22:02 socket-security[bot]

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

socket-security[bot] avatar Feb 22 '24 19:02 socket-security[bot]

Builds ready [f39caf5]
Page Load Metrics (962 ± 418 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint762131294019
domContentLoaded1082382010
load602024962872418
domInteractive1082382010
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

metamaskbot avatar Feb 26 '24 23:02 metamaskbot

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 68.60%. Comparing base (610f4a1) to head (52e0ddb).

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop   #23029   +/-   ##
========================================
  Coverage    68.60%   68.60%           
========================================
  Files         1098     1098           
  Lines        43319    43319           
  Branches     11557    11557           
========================================
  Hits         29715    29715           
  Misses       13604    13604

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 26 '24 23:02 codecov[bot]

Builds ready [029a6f9]
Page Load Metrics (1022 ± 456 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint642711335325
domContentLoaded1175322110
load5121981022950456
domInteractive1175322110
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

metamaskbot avatar Feb 27 '24 19:02 metamaskbot

Builds ready [52e0ddb]
Page Load Metrics (1322 ± 386 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint832411444220
domContentLoaded1378402311
load6920581322803386
domInteractive1378402311
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

metamaskbot avatar Feb 27 '24 22:02 metamaskbot