metamask-extension icon indicating copy to clipboard operation
metamask-extension copied to clipboard

Multichain: Amon Hen Test Fixture Creation

Open vthomas13 opened this issue 1 year ago • 3 comments

Description

Adding a method to the fixture-builder to help provide dapp connection data for Amon Hen features to test with.

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/2081

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • [ ] I’ve followed MetaMask Coding Standards.
  • [ ] I've clearly explained what problem this PR is solving and how it is solved.
  • [ ] I've linked related issues
  • [ ] I've included manual testing steps
  • [ ] I've included screenshots/recordings if applicable
  • [ ] I’ve included tests if applicable
  • [ ] I’ve documented my code using JSDoc format if applicable
  • [ ] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • [ ] I’ve properly set the pull request status:
    • [ ] In case it's not yet "ready for review", I've set it to "draft".
    • [ ] In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

vthomas13 avatar Feb 16 '24 17:02 vthomas13

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] avatar Feb 16 '24 17:02 github-actions[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (538601f) 68.53% compared to head (f541846) 68.53%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #23008   +/-   ##
========================================
  Coverage    68.53%   68.53%           
========================================
  Files         1089     1089           
  Lines        42980    42980           
  Branches     11442    11442           
========================================
  Hits         29455    29455           
  Misses       13525    13525           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 16 '24 17:02 codecov[bot]

Builds ready [f541846]
Page Load Metrics (1025 ± 64 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1044941917938
domContentLoaded10105282412
load7671402102513364
domInteractive10105282412
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

metamaskbot avatar Feb 16 '24 17:02 metamaskbot