metamask-extension icon indicating copy to clipboard operation
metamask-extension copied to clipboard

feat: Delay network controller provider initialization

Open pedronfigueiredo opened this issue 1 year ago • 2 comments

Description

We want to have finer control over the initialization of the network controller inside the metamask controller. For additional background and reasoning, see the tickets linked below.

This PR also depends on 2 PRs (#274 on the smart transactions controller repo and #4004 on the core repo) being merged and the corresponding packages released first. Once that is done, I will update the dependencies on this PR.

Related issues

Fixes: #2114 on the planning repo (For more details see also #881)

See: PR #274 on the smart transactions controller repo and PR #4004 on the core repo.

Manual testing steps

  • Checkout develop.
  • Run yarn && yarn dist.
  • When onboarding the extension, you should see the requests on the background console.
  • Checkout this branch.
  • Clone the SmartTransactionController repository.
  • Checkout this PR and build.
  • Clone the Core repository.
  • Checkout this PR and build.
  • Add these two lines to the resolutions section of the package.json.
    "@metamask/transaction-controller@^23.1.0": "file:../core/packages/transaction-controller",
    "@metamask/smart-transactions-controller@^6.2.2": "file:../smart-transactions-controller",
  • You may need to run yarn && yarn lavamoat:auto.
  • Run yarn && yarn dist.
  • No requests to the RPC node will be made before the advanced settings during onboarding.

Screenshots/Recordings

N/A

Pre-merge author checklist

  • [x] I’ve followed MetaMask Coding Standards.
  • [x] I've clearly explained what problem this PR is solving and how it is solved.
  • [x] I've linked related issues
  • [x] I've included manual testing steps
  • [x] I've included screenshots/recordings if applicable
  • [ ] I’ve included tests if applicable
  • [x] I’ve documented my code using JSDoc format if applicable
  • [x] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • [x] I’ve properly set the pull request status:
    • [x] In case it's not yet "ready for review", I've set it to "draft".
    • [ ] In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

pedronfigueiredo avatar Feb 16 '24 15:02 pedronfigueiredo

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] avatar Feb 16 '24 15:02 github-actions[bot]

This PR has been automatically marked as stale because it has not had recent activity in the last 60 days. It will be closed in 14 days. Thank you for your contributions.

github-actions[bot] avatar May 10 '24 02:05 github-actions[bot]

Closing this PR as the work has been handed over to the Extension Platform team.

pedronfigueiredo avatar Jun 25 '24 15:06 pedronfigueiredo