metamask-extension
metamask-extension copied to clipboard
[MMI] Removed unused methods
Description
In the CustodyController
institutional package, we have two methods, getCustodianConnectRequest
and setCustodianConnectRequest
, that are not being used in the monorepo, so this ticket aims to remove them.
Related issues
Fixes: https://consensyssoftware.atlassian.net/browse/MMI-4578
Manual testing steps
- Go to this page...
Screenshots/Recordings
Before
After
Pre-merge author checklist
- [x] I’ve followed MetaMask Coding Standards.
- [x] I've clearly explained what problem this PR is solving and how it is solved.
- [x] I've linked related issues
- [x] I've included manual testing steps
- [x] I've included screenshots/recordings if applicable
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using JSDoc format if applicable
- [x] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
- [ ] I’ve properly set the pull request status:
- [ ] In case it's not yet "ready for review", I've set it to "draft".
- [ ] In case it's "ready for review", I've changed it from "draft" to "non-draft".
Pre-merge reviewer checklist
- [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.
Builds ready [7f27cdd]
- builds: chrome, firefox
- builds (beta): chrome
- builds (flask): chrome, firefox
- builds (MMI): chrome, firefox
- builds (test): chrome, firefox
- builds (test-flask): chrome, firefox
- build viz: Build System
- mv3: Background Module Init Stats
- mv3: UI Init Stats
- mv3: Module Load Stats
- mv3: Bundle Size Stats
- mv2: E2e Actions Stats
- code coverage: Report
- storybook: Storybook
- typescript migration: Dashboard
- all artifacts
Page Load Metrics (1234 ± 124 ms)
Platform | Page | Metric | Min (ms) | Max (ms) | Average (ms) | StandardDeviation (ms) | MarginOfError (ms) |
---|---|---|---|---|---|---|---|
Chrome | Home | firstPaint | 122 | 474 | 207 | 75 | 36 |
domContentLoaded | 10 | 80 | 39 | 25 | 12 | ||
load | 997 | 2152 | 1234 | 258 | 124 | ||
domInteractive | 10 | 80 | 39 | 25 | 12 |
Bundle size diffs
- background: 0 Bytes (0.00%)
- ui: 0 Bytes (0.00%)
- common: 0 Bytes (0.00%)
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
c50613a
) 68.54% compared to head (7f27cdd
) 68.55%.
Additional details and impacted files
@@ Coverage Diff @@
## develop #23000 +/- ##
===========================================
+ Coverage 68.54% 68.55% +0.01%
===========================================
Files 1089 1089
Lines 42974 42957 -17
Branches 11442 11438 -4
===========================================
- Hits 29453 29446 -7
+ Misses 13521 13511 -10
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.