metamask-extension
metamask-extension copied to clipboard
[MMI] Adding capture exceptions to MMI controllers
Description
At the moment we are not capturing any error related to custodian via Sentry (pre-merge it has worked) - for better troubleshooting
Related issues
Fixes: https://consensyssoftware.atlassian.net/browse/MMI-4111
Manual testing steps
- Go to this page...
Screenshots/Recordings
Before
After
Pre-merge author checklist
- [ ] I’ve followed MetaMask Coding Standards.
- [ ] I've clearly explained what problem this PR is solving and how it is solved.
- [ ] I've linked related issues
- [ ] I've included manual testing steps
- [ ] I've included screenshots/recordings if applicable
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using JSDoc format if applicable
- [ ] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
- [ ] I’ve properly set the pull request status:
- [ ] In case it's not yet "ready for review", I've set it to "draft".
- [ ] In case it's "ready for review", I've changed it from "draft" to "non-draft".
Pre-merge reviewer checklist
- [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.
Codecov Report
Attention: 2 lines
in your changes are missing coverage. Please review.
Comparison is base (
61b5a19
) 68.47% compared to head (380fafa
) 68.46%. Report is 1 commits behind head on develop.
Files | Patch % | Lines |
---|---|---|
app/scripts/controllers/mmi-controller.js | 0.00% | 2 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## develop #22994 +/- ##
===========================================
- Coverage 68.47% 68.46% -0.01%
===========================================
Files 1089 1089
Lines 43027 43030 +3
Branches 11462 11462
===========================================
- Hits 29459 29458 -1
- Misses 13568 13572 +4
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Builds ready [380fafa]
- builds: chrome, firefox
- builds (beta): chrome
- builds (flask): chrome, firefox
- builds (MMI): chrome, firefox
- builds (test): chrome, firefox
- builds (test-flask): chrome, firefox
- build viz: Build System
- mv3: Background Module Init Stats
- mv3: UI Init Stats
- mv3: Module Load Stats
- mv3: Bundle Size Stats
- mv2: E2e Actions Stats
- code coverage: Report
- storybook: Storybook
- typescript migration: Dashboard
- all artifacts
Page Load Metrics (1429 ± 140 ms)
Platform | Page | Metric | Min (ms) | Max (ms) | Average (ms) | StandardDeviation (ms) | MarginOfError (ms) |
---|---|---|---|---|---|---|---|
Chrome | Home | firstPaint | 135 | 563 | 248 | 102 | 49 |
domContentLoaded | 11 | 144 | 54 | 30 | 15 | ||
load | 935 | 2054 | 1429 | 292 | 140 | ||
domInteractive | 11 | 144 | 54 | 30 | 15 |
Bundle size diffs
- background: 0 Bytes (0.00%)
- ui: 0 Bytes (0.00%)
- common: 0 Bytes (0.00%)