metamask-extension icon indicating copy to clipboard operation
metamask-extension copied to clipboard

[MMI] Adding capture exceptions to MMI controllers

Open albertolive opened this issue 1 year ago • 1 comments

Description

At the moment we are not capturing any error related to custodian via Sentry (pre-merge it has worked) - for better troubleshooting

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/MMI-4111

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • [ ] I’ve followed MetaMask Coding Standards.
  • [ ] I've clearly explained what problem this PR is solving and how it is solved.
  • [ ] I've linked related issues
  • [ ] I've included manual testing steps
  • [ ] I've included screenshots/recordings if applicable
  • [ ] I’ve included tests if applicable
  • [ ] I’ve documented my code using JSDoc format if applicable
  • [ ] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • [ ] I’ve properly set the pull request status:
    • [ ] In case it's not yet "ready for review", I've set it to "draft".
    • [ ] In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

albertolive avatar Feb 16 '24 10:02 albertolive

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] avatar Feb 16 '24 10:02 github-actions[bot]

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (61b5a19) 68.47% compared to head (380fafa) 68.46%. Report is 1 commits behind head on develop.

Files Patch % Lines
app/scripts/controllers/mmi-controller.js 0.00% 2 Missing :warning:
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #22994      +/-   ##
===========================================
- Coverage    68.47%   68.46%   -0.01%     
===========================================
  Files         1089     1089              
  Lines        43027    43030       +3     
  Branches     11462    11462              
===========================================
- Hits         29459    29458       -1     
- Misses       13568    13572       +4     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 20 '24 15:02 codecov[bot]

Builds ready [380fafa]
Page Load Metrics (1429 ± 140 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint13556324810249
domContentLoaded11144543015
load93520541429292140
domInteractive11144543015
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

metamaskbot avatar Feb 20 '24 15:02 metamaskbot