metamask-extension icon indicating copy to clipboard operation
metamask-extension copied to clipboard

Added generic polling hook

Open shanejonas opened this issue 1 year ago • 5 comments

Description

This adds a generic polling hook to provide a standardized way to poll UI information that is in multichain controllers. First starting with gas fee controller example implementation.

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/1322

Manual testing steps

  1. Click Send button
  2. on confirmation page check that the gas fee updates

shanejonas avatar Feb 15 '24 21:02 shanejonas

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] avatar Feb 15 '24 21:02 github-actions[bot]

Builds ready [556a765]
Page Load Metrics (1086 ± 65 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1262741894320
domContentLoaded9125393517
load8251391108613565
domInteractive9125393517
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 144 Bytes (0.00%)
  • ui: 946 Bytes (0.01%)
  • common: 0 Bytes (0.00%)

metamaskbot avatar Feb 15 '24 21:02 metamaskbot

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (a13de55) 68.47% compared to head (d8bb41d) 68.56%.

:exclamation: Current head d8bb41d differs from pull request most recent head 93973ce. Consider uploading reports for the commit 93973ce to get more accurate results

Files Patch % Lines
app/scripts/metamask-controller.js 0.00% 4 Missing :warning:
ui/store/actions.ts 0.00% 4 Missing :warning:
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #22980      +/-   ##
===========================================
+ Coverage    68.47%   68.56%   +0.09%     
===========================================
  Files         1089     1089              
  Lines        43063    42924     -139     
  Branches     11475    11421      -54     
===========================================
- Hits         29485    29427      -58     
+ Misses       13578    13497      -81     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 15 '24 21:02 codecov[bot]

Builds ready [d8bb41d]
Page Load Metrics (979 ± 54 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1162091862512
domContentLoaded972292110
load896139397911354
domInteractive972292110
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 144 Bytes (0.00%)
  • ui: 1003 Bytes (0.01%)
  • common: 0 Bytes (0.00%)

metamaskbot avatar Feb 16 '24 17:02 metamaskbot

Builds ready [1c6d5ea]
Page Load Metrics (1060 ± 72 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint8060721310550
domContentLoaded982252010
load7451503106015072
domInteractive982252010
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 144 Bytes (0.00%)
  • ui: 1003 Bytes (0.01%)
  • common: 0 Bytes (0.00%)

metamaskbot avatar Feb 16 '24 18:02 metamaskbot