metamask-extension icon indicating copy to clipboard operation
metamask-extension copied to clipboard
verified publisher icon MetaMask

comment out effect in new-network-info

Open jiexi opened this issue 1 year ago • 2 comments

Description

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • [ ] I’ve followed MetaMask Coding Standards.
  • [ ] I've clearly explained what problem this PR is solving and how it is solved.
  • [ ] I've linked related issues
  • [ ] I've included manual testing steps
  • [ ] I've included screenshots/recordings if applicable
  • [ ] I’ve included tests if applicable
  • [ ] I’ve documented my code using JSDoc format if applicable
  • [ ] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • [ ] I’ve properly set the pull request status:
    • [ ] In case it's not yet "ready for review", I've set it to "draft".
    • [ ] In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

jiexi avatar Feb 14 '24 23:02 jiexi

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] avatar Feb 14 '24 23:02 github-actions[bot]

Bisect Logs:

  • 90ae4980b3aca3f2610a24ade06cf7e6db928209

    • Feb 28th, 2023
    • does not occur

  • 131321af00a79a25d4e92222df82157a9ee347cf

    • Aug 29th, 2023
    • does not occur

  • 224bd6e35cd9d73f622bcb8a389b2ae77a8edd19

    • Nov 30th, 2023
    • occurs

  • 74a7ab58d9e98bec68f57980294d11e4b16bdac6

    • Oct 31st, 2023
    • occurs

  • 0a215ca2d89958b5bb3902490530b06565114e61

    • Sep 30th, 2023
    • occurs

  • f134493285a23b04332f2bad135acce109770b1b

    • Sep 15th, 2023
    • I don't think so? Didn't see the empty error message But seemed to be able to get the provider/wallet unresponsive when trying to add an rpc confirmation shows spinner and then I closed the modal and tried to continue to use the dapp/wallet ui
    • if you wait for the spinner to finish, you'll get a try again and switch network buttons. Clicking switch networks and changing the network ensures you are not locked up

  • 315c043785cd5d7a4b0f7e974097ccac18a6b241

    • Sep 22nd, 2023
    • occurs

  • 9f7ccfcea8241eddf7f5c92b2fdb2a39c83f5c9d

    • Sep 20th
    • does not occur

  • 0bc3aa9a928c8835cc3fad7d2579d55ec96c90d7

    • Sep 21st
    • does not occur

  • 55475df0b3b616f27f4ef4df9b0156acdf370f0e

    • Sep 22nd, 2023 commit right before 315c0437
    • occurs

  • 967ed42aeff8385bf91bdabcb0087ec57b909da7

    • mid day Sep 22nd
    • occurs

  • 1e65bb81683e3852d53ef6d835cac1c9798fb4bd

    • quarter day Sep 22nd
    • does not occur

  • 439de24573839aa4b5e56a2075ae3202a3bf294b

    • middle of 967ed42 and 1e65bb81
    • does not occur

  • 5f368d5807738aaa9fe50c259ede2eb2c31c3825

    • commit right before 967ed42a
    • occurs

  • d587999929dbd596d7d6447ac8c36c7da7f02920

    • commit right after 439de24 (right before 5f368d5)
    • I don't think so? Didn't see the empty error message
    • i don't seem to get a spinner when the rpc can't be reached, but canceling and continuing with other rpc seems fine

  • 5f368d5807738aaa9fe50c259ede2eb2c31c3825

    • confirmed occurs again
    • WE HAVE CULPRIT

jiexi avatar Feb 14 '24 23:02 jiexi