metamask-extension icon indicating copy to clipboard operation
metamask-extension copied to clipboard

[Bug]: Upon swap completion if user clicks away then returns to extension, a draft swap of what was just completed is presented

Open plasmacorral opened this issue 1 year ago • 0 comments

Describe the bug

I observed in testing 11.11.0 RC commit https://github.com/MetaMask/metamask-extension/commit/6d34630bb78be87da26ee45efad4fcf29d332b87, and confirmed that this is the experience in production 11.10.0.

When I complete a swap in pop-up view, if I click away and then come back to extension then a draft of my previously completed swap is presented. I have to hit back to then return to wallet view and appreciate that the swap did actually go through. User should not have to click the CTA to complete the swap.

Expected behavior

Given I just submitted a swap When I click away from pop-up view without clicking Close CTA Then the completion confirmation should be dismissed

Screenshots/Recordings

Recording: https://recordit.co/flMT7j5va9

Steps to reproduce

  1. Have wallet configured and an account with mainnet assets to swap
  2. Be in pop-up view
  3. Initiate a swap
  4. Once complete, click away from extension pop-up window without hitting Close
  5. Open extension again
  6. Note that draft swap is presented
  7. Hit back to see activity

Error messages or log output

No response

Version

11.10.0

Build type

None

Browser

Chrome

Operating system

MacOS

Hardware wallet

No response

Additional context

No response

Severity

This is a minor annoyance with a work around, but could create a moment of temporary alarm that the swap failed or needs to be resubmitted. This might erode confidence and could be avoided.

plasmacorral avatar Feb 14 '24 22:02 plasmacorral