metamask-extension
metamask-extension copied to clipboard
Create new inline contract-details field for easier verification
Description
Verifying signatures sources is quite important and moving the verification to a modal removes the context of what the verifying address is doing. Moving it inline and potentially linking in information from the associated NFT or ERC-20 contracts can better alert users to what they are doing and allow for super users to have better context when parsing signature transactions.
A signature associated with a low market cap coin while there is another with a high market cap coin can be confusing and a huge difference.
Related issues
Fixes:
Manual testing steps
- Attempt to sign a typed message
- See the verifying address inline rather than in a modal
- Allows for 1-click verification and (in the future) better display if you are signing against a ERC 20 / 721 token.
Screenshots/Recordings
Before
After
Pre-merge author checklist
- [x] I’ve followed MetaMask Coding Standards.
- [x] I've clearly explained what problem this PR is solving and how it is solved.
- [ ] I've linked related issues
- [ ] I've included manual testing steps
- [x] I've included screenshots/recordings if applicable
- [ ] I’ve included tests if applicable
- [x] I’ve documented my code using JSDoc format if applicable
- [ ] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
- [ ] I’ve properly set the pull request status:
- [x] In case it's not yet "ready for review", I've set it to "draft".
- [ ] In case it's "ready for review", I've changed it from "draft" to "non-draft".
Pre-merge reviewer checklist
- [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.
I have read the CLA Document and I hereby sign the CLA
This PR has been automatically marked as stale because it has not had recent activity in the last 60 days. It will be closed in 14 days. Thank you for your contributions.
This PR was closed because there has been no follow up activity in the last 14 days. Thank you for your contributions.