metamask-extension icon indicating copy to clipboard operation
metamask-extension copied to clipboard

Add Erc4337 to list of account types that do not support smart transactions

Open dbrans opened this issue 1 year ago • 1 comments

Description

Rationale from internal ticket:

The extension support smart swaps which are swap transactions that are submitted to a private node via the SmartTransactionsController.

These are not currently compatible with user operations since the bundler specified by the account snap would need to submit all transactions to our private node, plus this would limit the privacy aspect since the transaction intent would be visible to the bundler and potentially others via RPC methods.

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/2004

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • [x] I’ve followed MetaMask Coding Standards.
  • [x] I've clearly explained what problem this PR is solving and how it is solved.
  • [x] I've linked related issues
  • [x] I've included manual testing steps
  • [x] I've included screenshots/recordings if applicable
  • [x] I’ve included tests if applicable
  • [x] I’ve documented my code using JSDoc format if applicable
  • [x] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • [x] I’ve properly set the pull request status:
    • [x] In case it's not yet "ready for review", I've set it to "draft".
    • [x] In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

dbrans avatar Feb 14 '24 20:02 dbrans

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] avatar Feb 14 '24 20:02 github-actions[bot]

As this selector already exists and prevents smart transactions with snap accounts, then this ticket is already completed since 4337 accounts are a subset of snap accounts.

Closing.

dbrans avatar Feb 16 '24 13:02 dbrans