metamask-extension icon indicating copy to clipboard operation
metamask-extension copied to clipboard

Published 20 hours ago • verified publisher icon MetaMask

Bump eth-snap-keyring to v2.1.2

Open tmashuang opened this issue 1 year ago • 10 comments

Description

Bumps eth-snap-keyring to v2.1.2 which only included a bump of eth-sig-util which fixes v4 typed data signing for snap created accounts. https://github.com/MetaMask/eth-snap-keyring/releases/tag/v2.1.2 https://github.com/MetaMask/eth-sig-util/releases/tag/v7.0.1

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • [x] I’ve followed MetaMask Coding Standards.
  • [x] I've clearly explained what problem this PR is solving and how it is solved.
  • [x] I've linked related issues
  • [x] I've included manual testing steps
  • [x] I've included screenshots/recordings if applicable
  • [x] I’ve included tests if applicable
  • [x] I’ve documented my code using JSDoc format if applicable
  • [x] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • [x] I’ve properly set the pull request status:
    • [x] In case it's not yet "ready for review", I've set it to "draft".
    • [x] In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

tmashuang avatar Feb 14 '24 19:02 tmashuang

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] avatar Feb 14 '24 19:02 github-actions[bot]

@metamaskbot update-policies

tmashuang avatar Feb 14 '24 19:02 tmashuang

Policies updated

metamaskbot avatar Feb 14 '24 19:02 metamaskbot

@metamaskbot update-policies

tmashuang avatar Feb 14 '24 20:02 tmashuang

Policies updated

metamaskbot avatar Feb 14 '24 20:02 metamaskbot

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (4d381e9) 68.54% compared to head (c868ac4) 68.54%. Report is 1 commits behind head on develop.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop   #22955   +/-   ##
========================================
  Coverage    68.54%   68.54%           
========================================
  Files         1088     1088           
  Lines        42936    42936           
  Branches     11427    11427           
========================================
  Hits         29430    29430           
  Misses       13506    13506

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 14 '24 21:02 codecov[bot]

Builds ready [29b73e7]
Page Load Metrics (965 ± 34 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1183011804320
domContentLoaded1070332311
load84110999657034
domInteractive1070332311
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 2.15 KiB (0.06%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

metamaskbot avatar Feb 14 '24 21:02 metamaskbot

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@noble/[email protected] None 0 84.8 kB paulmillr
npm/@types/[email protected] None +1 9.65 kB types
npm/@types/[email protected] None 0 3.2 kB types
npm/@types/[email protected] None 0 2.8 kB types
npm/@xstate/[email protected] environment 0 57.1 kB xstate-release-bot
npm/[email protected] None 0 8.52 kB zkochan
npm/[email protected] None 0 788 kB vitaly

🚮 Removed packages: npm/@scure/[email protected], npm/@scure/[email protected], npm/@scure/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

socket-security[bot] avatar Feb 14 '24 21:02 socket-security[bot]

Builds ready [ec823ad]
Page Load Metrics (1199 ± 101 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1355022177335
domContentLoaded13120503115
load93417411199210101
domInteractive13120503115
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 2.15 KiB (0.06%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

metamaskbot avatar Feb 14 '24 21:02 metamaskbot

Builds ready [23ded34]
Page Load Metrics (1009 ± 85 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1202561863718
domContentLoaded986292311
load9011745100917785
domInteractive986292311
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 2.15 KiB (0.06%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

metamaskbot avatar Feb 14 '24 22:02 metamaskbot

Builds ready [c26a8f2]
Page Load Metrics (1036 ± 32 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1262811893316
domContentLoaded1072382512
load913118310366732
domInteractive1072382512
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 2.15 KiB (0.06%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

metamaskbot avatar Feb 15 '24 02:02 metamaskbot

FWIW, @metamask/eth-snap-keyring already gets the fixed [email protected] in metamask-extension since #21928 makes that the case for specifications of eth-sig-util@^7.0.0: https://github.com/MetaMask/metamask-extension/blob/9c59da5eed962602fc787426cff2d3fb581c7de4/yarn.lock#L4007-L4009

I guess the main change here is really https://github.com/MetaMask/eth-snap-keyring/pull/203/files (and so @metamask/[email protected] would have been more appropriately been released as 2.2.0 with an entry for that in changelog).

legobeat avatar Feb 15 '24 06:02 legobeat

Builds ready [454ea20]
Page Load Metrics (989 ± 25 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1152892013216
domContentLoaded1073312211
load90710939895125
domInteractive1073312211
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 2.15 KiB (0.06%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

metamaskbot avatar Feb 15 '24 18:02 metamaskbot

Builds ready [c868ac4]
Page Load Metrics (1042 ± 77 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1004061967436
domContentLoaded10151404220
load8071472104216077
domInteractive10151404220
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 2.15 KiB (0.06%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

metamaskbot avatar Feb 15 '24 20:02 metamaskbot