metamask-extension icon indicating copy to clipboard operation
metamask-extension copied to clipboard

Updated GasFeeController to latest package version

Open shanejonas opened this issue 1 year ago • 12 comments

Description

This bumps GasFeeController to the latest package version

shanejonas avatar Feb 14 '24 19:02 shanejonas

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] avatar Feb 14 '24 19:02 github-actions[bot]

@metamaskbot update-policies

shanejonas avatar Feb 14 '24 19:02 shanejonas

@metamaskbot update-policies

shanejonas avatar Feb 14 '24 20:02 shanejonas

Policies updated

metamaskbot avatar Feb 14 '24 20:02 metamaskbot

No policy changes

metamaskbot avatar Feb 14 '24 20:02 metamaskbot

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (3d38143) 68.54% compared to head (36ab7ba) 68.54%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #22954   +/-   ##
========================================
  Coverage    68.54%   68.54%           
========================================
  Files         1088     1088           
  Lines        42908    42908           
  Branches     11414    11414           
========================================
  Hits         29410    29410           
  Misses       13498    13498           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 14 '24 20:02 codecov[bot]

Builds ready [3a460fd]
Page Load Metrics (1069 ± 72 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1223322055124
domContentLoaded11107492613
load7611352106915172
domInteractive11107492613
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 254 Bytes (0.01%)
  • ui: 0 Bytes (0.00%)
  • common: 9.09 KiB (0.18%)

metamaskbot avatar Feb 14 '24 20:02 metamaskbot

Looks like this bump requires that @metamask/network-controller be bumped to v17.2.0 per the changelog: https://github.com/MetaMask/core/blob/main/packages/gas-fee-controller/CHANGELOG.md

adonesky1 avatar Feb 14 '24 20:02 adonesky1

@metamaskbot update-policies

shanejonas avatar Feb 14 '24 21:02 shanejonas

No policy changes

metamaskbot avatar Feb 14 '24 21:02 metamaskbot

Builds ready [20265e3]
Page Load Metrics (1097 ± 34 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1132991955024
domContentLoaded1069322010
load991121410977234
domInteractive1069322010
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 254 Bytes (0.01%)
  • ui: 0 Bytes (0.00%)
  • common: 9.09 KiB (0.18%)

metamaskbot avatar Feb 14 '24 22:02 metamaskbot

Builds ready [36ab7ba]
Page Load Metrics (977 ± 43 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1164041956029
domContentLoaded1096383014
load79412059779143
domInteractive1096383014
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 254 Bytes (0.01%)
  • ui: 0 Bytes (0.00%)
  • common: 9.09 KiB (0.18%)

metamaskbot avatar Feb 14 '24 22:02 metamaskbot