metamask-extension icon indicating copy to clipboard operation
metamask-extension copied to clipboard

[MMI] 4564 - fix the way get custody type was being done

Open zone-live opened this issue 2 years ago • 1 comments

Description

We were hardcoding the custody type to always be JSON-RPC, but in reality it can be also ECA3, or a legacy custodian such as Qredo. Therefore we now get this value the correct way.

Ref ticket

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • [ ] I’ve followed MetaMask Coding Standards.
  • [ ] I've clearly explained what problem this PR is solving and how it is solved.
  • [ ] I've linked related issues
  • [ ] I've included manual testing steps
  • [ ] I've included screenshots/recordings if applicable
  • [ ] I’ve included tests if applicable
  • [ ] I’ve documented my code using JSDoc format if applicable
  • [ ] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • [ ] I’ve properly set the pull request status:
    • [ ] In case it's not yet "ready for review", I've set it to "draft".
    • [ ] In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

zone-live avatar Feb 14 '24 16:02 zone-live

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] avatar Feb 14 '24 16:02 github-actions[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (12a0770) 68.54% compared to head (055830e) 68.54%. Report is 3 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #22950      +/-   ##
===========================================
- Coverage    68.54%   68.54%   -0.00%     
===========================================
  Files         1088     1088              
  Lines        42904    42905       +1     
  Branches     11413    11414       +1     
===========================================
  Hits         29408    29408              
- Misses       13496    13497       +1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 15 '24 09:02 codecov[bot]

Builds ready [055830e]
Page Load Metrics (1042 ± 52 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1234701867034
domContentLoaded874342311
load8451403104210852
domInteractive874342311
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

metamaskbot avatar Feb 15 '24 09:02 metamaskbot