metamask-extension icon indicating copy to clipboard operation
metamask-extension copied to clipboard

Published 20 hours ago • verified publisher icon MetaMask

Show modal when user tries to cancel confirmed transaction

Open OGPoyraz opened this issue 1 year ago • 10 comments

Description

If user tries to cancel transaction which is already confirmed, we would like to show them a modal to show a link to block explorer.

Related issues

Fixes: https://github.com/MetaMask/metamask-extension/issues/22314 Related: https://github.com/MetaMask/metamask-extension/issues/22663

Manual testing steps

Please see the recording.

Screenshots/Recordings

https://github.com/MetaMask/metamask-extension/assets/7644512/861ef616-89a4-4292-8a2b-8a1733f2d88b

Pre-merge author checklist

  • [x] I’ve followed MetaMask Coding Standards.
  • [x] I've clearly explained what problem this PR is solving and how it is solved.
  • [x] I've linked related issues
  • [x] I've included manual testing steps
  • [x] I've included screenshots/recordings if applicable
  • [ ] I’ve included tests if applicable
  • [ ] I’ve documented my code using JSDoc format if applicable
  • [ ] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • [ ] I’ve properly set the pull request status:
    • [ ] In case it's not yet "ready for review", I've set it to "draft".
    • [ ] In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

OGPoyraz avatar Feb 14 '24 12:02 OGPoyraz

@metamaskbot update-policies

OGPoyraz avatar Feb 14 '24 12:02 OGPoyraz

No policy changes

metamaskbot avatar Feb 14 '24 13:02 metamaskbot

@metamaskbot update-policies

OGPoyraz avatar Feb 16 '24 09:02 OGPoyraz

Policy update failed. You can review the logs or retry the policy update here

metamaskbot avatar Feb 16 '24 09:02 metamaskbot

@metamaskbot update-policies

OGPoyraz avatar Feb 16 '24 09:02 OGPoyraz

Policies updated

metamaskbot avatar Feb 16 '24 09:02 metamaskbot

Builds ready [0153884]
Page Load Metrics (1028 ± 53 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1212331653216
domContentLoaded10105322914
load8481230102811153
domInteractive10105322914
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 2.21 KiB (0.07%)
  • ui: 7.35 KiB (0.11%)
  • common: 26.54 KiB (0.53%)

metamaskbot avatar Feb 16 '24 10:02 metamaskbot

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (d87b631) 68.49% compared to head (14878c4) 68.52%.

Files Patch % Lines
...lready-confirmed/transaction-already-confirmed.tsx 75.00% 3 Missing :warning:
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop   #22943      +/-   ##
===========================================
+ Coverage    68.49%   68.52%   +0.04%     
===========================================
  Files         1090     1092       +2     
  Lines        43133    43153      +20     
  Branches     11501    11502       +1     
===========================================
+ Hits         29541    29570      +29     
+ Misses       13592    13583       -9

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 16 '24 10:02 codecov[bot]

New modal is successfully displayed when user attempts to cancel the transaction that was confirmed on blockchain, dev build commit 6bef80e, Chrome 121.0.6167.184:

https://github.com/MetaMask/metamask-extension/assets/104780023/b56a8a40-a9b6-4f31-a1b1-4988778afde1

sleepytanya avatar Feb 19 '24 05:02 sleepytanya

Builds ready [37403e1]
Page Load Metrics (1027 ± 40 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1222511744019
domContentLoaded10101362813
load847121010278440
domInteractive10101362813
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 2.21 KiB (0.07%)
  • ui: 6.64 KiB (0.10%)
  • common: 26.54 KiB (0.53%)

metamaskbot avatar Feb 19 '24 10:02 metamaskbot

@metamaskbot update-policies

OGPoyraz avatar Feb 22 '24 09:02 OGPoyraz

Policies updated

metamaskbot avatar Feb 22 '24 09:02 metamaskbot

Builds ready [c07848b]
Page Load Metrics (1993 ± 176 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint8948420511053
domContentLoaded10102392612
load156631011993367176
domInteractive10102392612
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 4.56 KiB (0.07%)
  • common: 193 Bytes (0.00%)

metamaskbot avatar Feb 22 '24 09:02 metamaskbot

Builds ready [14878c4]
Page Load Metrics (1733 ± 67 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint964321928842
domContentLoaded1083312411
load14932124173314067
domInteractive1083312411
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 4.56 KiB (0.07%)
  • common: 193 Bytes (0.00%)

metamaskbot avatar Feb 22 '24 14:02 metamaskbot