metamask-extension icon indicating copy to clipboard operation
metamask-extension copied to clipboard

fix: Blockaid disable disclosure scrollToBottom

Open digiwand opened this issue 1 year ago • 4 comments

Description

Replaces default Disclosure scrollToBottom behavior to fix issue where opening Blockaid Banner Alert "See Details" would scroll to the bottom

Adds tests for Disclosure component

Related issues

Fixes: https://github.com/MetaMask/metamask-extension/issues/21187

Manual testing steps

Screenshots/Recordings

Before

sdlg5Rty3W

After

ZHn0VM0UwG

Pre-merge author checklist

  • [ ] I’ve followed MetaMask Coding Standards.
  • [ ] I've clearly explained what problem this PR is solving and how it is solved.
  • [ ] I've linked related issues
  • [ ] I've included manual testing steps
  • [ ] I've included screenshots/recordings if applicable
  • [ ] I’ve included tests if applicable
  • [ ] I’ve documented my code using JSDoc format if applicable
  • [ ] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • [ ] I’ve properly set the pull request status:
    • [ ] In case it's not yet "ready for review", I've set it to "draft".
    • [ ] In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

digiwand avatar Feb 14 '24 04:02 digiwand

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] avatar Feb 14 '24 04:02 github-actions[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (391e9e7) 68.55% compared to head (a4be5c5) 68.55%. Report is 16 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #22932   +/-   ##
========================================
  Coverage    68.55%   68.55%           
========================================
  Files         1088     1088           
  Lines        42907    42906    -1     
  Branches     11415    11412    -3     
========================================
  Hits         29411    29411           
+ Misses       13496    13495    -1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 14 '24 04:02 codecov[bot]

Builds ready [533198b]
Page Load Metrics (1057 ± 67 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1232641773818
domContentLoaded108629209
load8091528105713967
domInteractive108629209
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 120 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

metamaskbot avatar Feb 14 '24 04:02 metamaskbot

Builds ready [a4be5c5]
Page Load Metrics (962 ± 57 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1362941883115
domContentLoaded986382613
load763140796211957
domInteractive986382613
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 176 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

metamaskbot avatar Feb 14 '24 22:02 metamaskbot