metamask-extension
metamask-extension copied to clipboard
Add All Permissions button to global menu, metrics
Description
Adding the button for All Permissions to the global menu, and relevant Metametrics. TODO: We want a new story to remove Connected Sites and the global menu item to access it, during cleanup.
Related issues
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/1940
Manual testing steps
- yarn && MULTICHAIN=1 yarn start
- open extension popup view
- open global menu in top-right and verify that All Permissions is an option and it Navi
Screenshots/Recordings
Before
After
Pre-merge author checklist
- [X] I’ve followed MetaMask Coding Standards.
- [X] I've clearly explained what problem this PR is solving and how it is solved.
- [X] I've linked related issues
- [X] I've included manual testing steps
- [X] I've included screenshots/recordings if applicable
- [X] I’ve included tests if applicable
- [X] I’ve documented my code using JSDoc format if applicable
- [X] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
- [X] I’ve properly set the pull request status:
- [X] In case it's not yet "ready for review", I've set it to "draft".
- [X] In case it's "ready for review", I've changed it from "draft" to "non-draft".
Pre-merge reviewer checklist
- [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.
Builds ready [1efabd1]
- builds: chrome, firefox
- builds (beta): chrome
- builds (flask): chrome, firefox
- builds (MMI): chrome, firefox
- builds (test): chrome, firefox
- builds (test-flask): chrome, firefox
- build viz: Build System
- mv3: Background Module Init Stats
- mv3: UI Init Stats
- mv3: Module Load Stats
- mv3: Bundle Size Stats
- mv2: E2e Actions Stats
- code coverage: Report
- storybook: Storybook
- typescript migration: Dashboard
- all artifacts
Page Load Metrics (1121 ± 73 ms)
Platform | Page | Metric | Min (ms) | Max (ms) | Average (ms) | StandardDeviation (ms) | MarginOfError (ms) |
---|---|---|---|---|---|---|---|
Chrome | Home | firstPaint | 98 | 300 | 201 | 53 | 25 |
domContentLoaded | 10 | 91 | 44 | 26 | 13 | ||
load | 908 | 1585 | 1121 | 151 | 73 | ||
domInteractive | 10 | 91 | 44 | 26 | 13 |
Bundle size diffs [🚨 Warning! Bundle size has increased!]
- background: 176 Bytes (0.01%)
- ui: 1.31 KiB (0.02%)
- common: 462 Bytes (0.01%)
Codecov Report
Attention: 4 lines
in your changes are missing coverage. Please review.
:exclamation: No coverage uploaded for pull request base (
1989-permissions-tour@6b4a4f2
). Click here to learn what that means.
Files | Patch % | Lines |
---|---|---|
...i/components/multichain/global-menu/global-menu.js | 33.33% | 4 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## 1989-permissions-tour #22929 +/- ##
========================================================
Coverage ? 68.53%
========================================================
Files ? 1088
Lines ? 42939
Branches ? 11424
========================================================
Hits ? 29425
Misses ? 13514
Partials ? 0
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Builds ready [969ffb0]
- builds: chrome, firefox
- builds (beta): chrome
- builds (flask): chrome, firefox
- builds (MMI): chrome, firefox
- builds (test): chrome, firefox
- builds (test-flask): chrome, firefox
- build viz: Build System
- mv3: Background Module Init Stats
- mv3: UI Init Stats
- mv3: Module Load Stats
- mv3: Bundle Size Stats
- mv2: E2e Actions Stats
- code coverage: Report
- storybook: Storybook
- typescript migration: Dashboard
- all artifacts
Page Load Metrics (1340 ± 110 ms)
Platform | Page | Metric | Min (ms) | Max (ms) | Average (ms) | StandardDeviation (ms) | MarginOfError (ms) |
---|---|---|---|---|---|---|---|
Chrome | Home | firstPaint | 119 | 435 | 253 | 79 | 38 |
domContentLoaded | 13 | 235 | 66 | 50 | 24 | ||
load | 956 | 1768 | 1340 | 230 | 110 | ||
domInteractive | 13 | 235 | 66 | 50 | 24 |
Bundle size diffs [🚨 Warning! Bundle size has increased!]
- background: 176 Bytes (0.01%)
- ui: 1.31 KiB (0.02%)
- common: 462 Bytes (0.01%)