metamask-extension icon indicating copy to clipboard operation
metamask-extension copied to clipboard

Add All Permissions button to global menu, metrics

Open vthomas13 opened this issue 1 year ago • 1 comments

Description

Adding the button for All Permissions to the global menu, and relevant Metametrics. TODO: We want a new story to remove Connected Sites and the global menu item to access it, during cleanup.

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/1940

Manual testing steps

  1. yarn && MULTICHAIN=1 yarn start
  2. open extension popup view
  3. open global menu in top-right and verify that All Permissions is an option and it Navi

Screenshots/Recordings

Before

After

image

Pre-merge author checklist

  • [X] I’ve followed MetaMask Coding Standards.
  • [X] I've clearly explained what problem this PR is solving and how it is solved.
  • [X] I've linked related issues
  • [X] I've included manual testing steps
  • [X] I've included screenshots/recordings if applicable
  • [X] I’ve included tests if applicable
  • [X] I’ve documented my code using JSDoc format if applicable
  • [X] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • [X] I’ve properly set the pull request status:
    • [X] In case it's not yet "ready for review", I've set it to "draft".
    • [X] In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

vthomas13 avatar Feb 13 '24 22:02 vthomas13

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] avatar Feb 13 '24 22:02 github-actions[bot]

Builds ready [1efabd1]
Page Load Metrics (1121 ± 73 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint983002015325
domContentLoaded1091442613
load9081585112115173
domInteractive1091442613
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 176 Bytes (0.01%)
  • ui: 1.31 KiB (0.02%)
  • common: 462 Bytes (0.01%)

metamaskbot avatar Feb 15 '24 15:02 metamaskbot

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

:exclamation: No coverage uploaded for pull request base (1989-permissions-tour@6b4a4f2). Click here to learn what that means.

Files Patch % Lines
...i/components/multichain/global-menu/global-menu.js 33.33% 4 Missing :warning:
Additional details and impacted files
@@                   Coverage Diff                    @@
##             1989-permissions-tour   #22929   +/-   ##
========================================================
  Coverage                         ?   68.53%           
========================================================
  Files                            ?     1088           
  Lines                            ?    42939           
  Branches                         ?    11424           
========================================================
  Hits                             ?    29425           
  Misses                           ?    13514           
  Partials                         ?        0           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 15 '24 15:02 codecov[bot]

Builds ready [969ffb0]
Page Load Metrics (1340 ± 110 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1194352537938
domContentLoaded13235665024
load95617681340230110
domInteractive13235665024
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 176 Bytes (0.01%)
  • ui: 1.31 KiB (0.02%)
  • common: 462 Bytes (0.01%)

metamaskbot avatar Feb 15 '24 15:02 metamaskbot