metamask-extension icon indicating copy to clipboard operation
metamask-extension copied to clipboard

Published 20 hours ago • verified publisher icon MetaMask

Adding Permissions Tour & Empty State

Open vthomas13 opened this issue 1 year ago • 7 comments

Description

This PR is for the conversion of the AllConnections component to the PermissionsPage component

Related issues

Fixes:https://github.com/MetaMask/MetaMask-planning/issues/1989

Manual testing steps

  1. yarn && MULTICHAIN=1 yarn start
  2. open fullscreen, add "#permissions" route to the end of the URL
  3. disconnect all dapps and verify empty state after no dapps are connected.

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • [X] I’ve followed MetaMask Coding Standards.
  • [X] I've clearly explained what problem this PR is solving and how it is solved.
  • [X] I've linked related issues
  • [X] I've included manual testing steps
  • [X] I've included screenshots/recordings if applicable
  • [X] I’ve included tests if applicable
  • [X] I’ve documented my code using JSDoc format if applicable
  • [X] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • [X] I’ve properly set the pull request status:
    • [X] In case it's not yet "ready for review", I've set it to "draft".
    • [X] In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

vthomas13 avatar Feb 12 '24 16:02 vthomas13

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] avatar Feb 12 '24 16:02 github-actions[bot]

Builds ready [155fd19]
Page Load Metrics (1393 ± 239 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1194942289847
domContentLoaded8104422813
load89727241393499239
domInteractive8104422813
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 176 Bytes (0.01%)
  • ui: 1.65 KiB (0.02%)
  • common: 375 Bytes (0.01%)

metamaskbot avatar Feb 13 '24 14:02 metamaskbot

Builds ready [fc4355d]
Page Load Metrics (972 ± 65 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1323692034723
domContentLoaded992412813
load831151897213665
domInteractive992412813
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 176 Bytes (0.01%)
  • ui: 1.56 KiB (0.02%)
  • common: 375 Bytes (0.01%)

metamaskbot avatar Feb 13 '24 20:02 metamaskbot

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (80d0822) 68.55% compared to head (cea6a2c) 68.53%. Report is 1 commits behind head on develop.

Files Patch % Lines
...i/components/multichain/global-menu/global-menu.js 33.33% 4 Missing :warning:
...tichain/pages/permissions-page/permissions-page.js 88.89% 4 Missing :warning:
ui/store/actions.ts 0.00% 2 Missing :warning:
app/scripts/controllers/app-state.js 0.00% 1 Missing :warning:
app/scripts/metamask-controller.js 0.00% 1 Missing :warning:
...chain/product-tour-popover/product-tour-popover.js 66.67% 1 Missing :warning:
ui/pages/routes/routes.component.js 66.67% 1 Missing :warning:
ui/selectors/selectors.js 95.00% 1 Missing :warning:
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop   #22905      +/-   ##
===========================================
- Coverage    68.55%   68.53%   -0.02%     
===========================================
  Files         1088     1088              
  Lines        42925    42939      +14     
  Branches     11417    11424       +7     
===========================================
+ Hits         29424    29426       +2     
- Misses       13501    13513      +12

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 13 '24 20:02 codecov[bot]

Builds ready [857ff66]
Page Load Metrics (1075 ± 44 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1342671943417
domContentLoaded976342612
load967132410759144
domInteractive976342612
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 176 Bytes (0.01%)
  • ui: 1.56 KiB (0.02%)
  • common: 375 Bytes (0.01%)

metamaskbot avatar Feb 13 '24 22:02 metamaskbot

Builds ready [6b4a4f2]
Page Load Metrics (1061 ± 52 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1223711925928
domContentLoaded980382612
load8451308106110852
domInteractive980382612
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 176 Bytes (0.01%)
  • ui: 1.3 KiB (0.02%)
  • common: 375 Bytes (0.01%)

metamaskbot avatar Feb 15 '24 15:02 metamaskbot

Builds ready [cea6a2c]
Page Load Metrics (1065 ± 59 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1193362085225
domContentLoaded13100352512
load8451407106512359
domInteractive13100352512
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 176 Bytes (0.01%)
  • ui: 1.31 KiB (0.02%)
  • common: 462 Bytes (0.01%)

metamaskbot avatar Feb 15 '24 18:02 metamaskbot