metamask-extension icon indicating copy to clipboard operation
metamask-extension copied to clipboard

chore(test/e2e): ensure test domains never map to publically resolvable names

Open legobeat opened this issue 1 year ago • 2 comments

Description

Some tests are using URLs that aren't intended to actually map to any public endpoints. Changing the TLD to .test ensures that these never map to any actual public domains.

cf RFC 2606 where the .test TLD is reserved for private use.

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • [x] I’ve followed MetaMask Coding Standards.
  • [x] I've clearly explained what problem this PR is solving and how it is solved.
  • [x] I've linked related issues
  • [x] I've included manual testing steps
  • [x] I've included screenshots/recordings if applicable
  • [x] I’ve included tests if applicable
  • [x] I’ve documented my code using JSDoc format if applicable
  • [x] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • [x] I’ve properly set the pull request status:
    • [x] In case it's not yet "ready for review", I've set it to "draft".
    • [x] In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

legobeat avatar Feb 08 '24 16:02 legobeat

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] avatar Feb 08 '24 16:02 github-actions[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 67.48%. Comparing base (e3207d4) to head (bc19342).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #22879      +/-   ##
===========================================
- Coverage    67.48%   67.48%   -0.00%     
===========================================
  Files         1288     1288              
  Lines        50153    50153              
  Branches     13023    13023              
===========================================
- Hits         33842    33841       -1     
- Misses       16311    16312       +1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Mar 05 '24 03:03 codecov[bot]

LGTM ! Thanks for the changes !

DDDDDanica avatar May 21 '24 11:05 DDDDDanica