metamask-extension icon indicating copy to clipboard operation
metamask-extension copied to clipboard

deps: eth-sig-util@^3.0.0 -> @metamask/eth-sig-util^7.0.1

Open legobeat opened this issue 1 year ago • 2 comments

Description

The direct dependency on eth-sig-util@^3.0.0 is quite old (2021-02). This updates it to latest @metamask/eth-sig-util@^7.0.1, which is already used transitively through dependencies. This allows us to drop some legacy deps (including a redundant patch and some allow-scripts config entries).

It's only actually used for its function for address normalization.

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • [x] I’ve followed MetaMask Coding Standards.
  • [x] I've clearly explained what problem this PR is solving and how it is solved.
  • [x] I've linked related issues
  • [ ] I've included manual testing steps
  • [x] I've included screenshots/recordings if applicable
  • [x] I’ve included tests if applicable
  • [x] I’ve documented my code using JSDoc format if applicable
  • [x] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • [x] I’ve properly set the pull request status:
    • [x] In case it's not yet "ready for review", I've set it to "draft".
    • [x] In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

legobeat avatar Feb 07 '24 21:02 legobeat

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] avatar Feb 07 '24 21:02 github-actions[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 68.72%. Comparing base (7b05334) to head (5e85e0d). Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #22862      +/-   ##
===========================================
- Coverage    68.73%   68.72%   -0.00%     
===========================================
  Files         1124     1124              
  Lines        43617    43617              
  Branches     11674    11674              
===========================================
- Hits         29976    29975       -1     
- Misses       13641    13642       +1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Mar 12 '24 10:03 codecov[bot]

No release label on PR. Adding release label release-11.14.0 on PR, as PR was added to branch 11.14.0 when release was cut.

metamaskbot avatar Mar 26 '24 00:03 metamaskbot