metamask-extension icon indicating copy to clipboard operation
metamask-extension copied to clipboard

deps: update ethjs packages to remove babel-runtime dependency

Open legobeat opened this issue 1 year ago • 3 comments

Description

Update @metamask/ethjs* packages for new versions built with babel 7 instead of babel 6. This removes the (peer)dependency on deprecated babel-runtime for these packages.

  • Bump @metamask/ethjs* packages to latest
    • Packages are now using bn.js v5 (matching direct dependency of metamask-extension) instead of v4.
  • Bump @metamask/eth-token-tracker from ^7.0.1 to ^7.0.2
  • Bump eth-method-registry from ^3.0.0 to ^4.0.0
    • Changelog
    • No breaking changes affecting metamask-extension
  • Bump @metamask/transaction-controller from ^21.1.0 to ^22.0.0
    • Changelog
    • No breaking changes affecting metamask-extension

Related issues

  • #22979 bumps @metamask/transaction-controller to ^23.0.0

Depends on

  • [x] Release of @metamask/transaction-controller>21.2.0
    • [x] https://github.com/MetaMask/core/pull/3897
      • [x] https://github.com/MetaMask/eth-method-registry/pull/63
        • [x] https://github.com/MetaMask/eth-method-registry/pull/62
          • [x] https://github.com/MetaMask/eth-method-registry/pull/61
            • [x] https://github.com/MetaMask/eth-method-registry/pull/58

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • [x] I’ve followed MetaMask Coding Standards.
  • [ ] I've clearly explained what problem this PR is solving and how it is solved.
  • [x] I've linked related issues
  • [ ] I've included manual testing steps
  • [x] I've included screenshots/recordings if applicable
  • [x] I’ve included tests if applicable
  • [x] I’ve documented my code using JSDoc format if applicable
  • [x] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • [x] I’ve properly set the pull request status:
    • [x] In case it's not yet "ready for review", I've set it to "draft".
    • [x] In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

legobeat avatar Feb 07 '24 19:02 legobeat

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] avatar Feb 07 '24 19:02 github-actions[bot]

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/[email protected] Transitive: network +3 470 kB lgbot
npm/@metamask/[email protected] Transitive: network +24 7.6 MB lgbot
npm/@metamask/[email protected] Transitive: environment, filesystem, network +124 27.5 MB brad.decker, danfinlay, gudahtt, ...9 more
npm/[email protected] filesystem 0 1.45 MB ldthomas
npm/[email protected] None +21 5.79 MB lgbot

🚮 Removed packages: npm/@metamask/[email protected]

View full report↗︎

socket-security[bot] avatar Feb 07 '24 19:02 socket-security[bot]

Note: As this PR stands, @metamask/user-operation-controller is still pulling in older versions through transitive dependency on @metamask/transaction-controller.

@metamask/transaction-controller required version per @metamask/user-operation-controller versions

$ nvs -p @metamask/transaction-controller @metamask/user-operation-controller
0.0.0   2023-12-14T19:09:38.724Z        >=16.0.0        null
1.0.0   2024-01-15T14:11:25.886Z        >=16.0.0        ^20.0.0
2.0.0   2024-01-23T21:48:03.387Z        >=16.0.0        ^21.0.0
3.0.0   2024-01-29T17:31:52.062Z        >=16.0.0        ^21.0.1
4.0.0   2024-02-15T23:34:56.424Z        >=16.0.0        ^23.0.0

@metamask/transaction-controller@>=22.0.0 removes the deprecated versions. @metamask/[email protected] contains some wider breaking changes and this upgrade is pending in #22979 .

legobeat avatar Feb 16 '24 08:02 legobeat

No release label on PR. Adding release label release-11.12.0 on PR, as PR was added to branch 11.12.0 when release was cut.

metamaskbot avatar Mar 01 '24 18:03 metamaskbot