metamask-extension icon indicating copy to clipboard operation
metamask-extension copied to clipboard

PPOM - Loading Spinner Style

Open seaona opened this issue 1 year ago • 2 comments

What is this about?

Context: in the 11.9 release, it has been introduced a loading spinner state for Extension, that is display and visible during the ppom validation. If it's fast, you almost don't see it, but if it's slow, you see a small spinner on top of the confirmations screens. (See below).

We want to add some styling, since specially in custom screens is hard to see.

This includes all screens and custom screens:

  • Signatures
  • Approve ERC
  • SetApproval for All
  • Transfer ERC
  • Send Eth

image

image

Scenario

No response

Design

No response

Technical Details

No response

Threat Modeling Framework

No response

Acceptance Criteria

No response

Stakeholder review needed before the work gets merged

  • [X] Engineering (needed in most cases)
  • [X] Design
  • [X] Product
  • [ ] QA (automation tests are required to pass before merging PRs but not all changes are covered by automation tests - please review if QA is needed beyond automation tests)
  • [ ] Security
  • [ ] Legal
  • [ ] Marketing
  • [ ] Management (please specify)
  • [ ] Other (please specify)

References

No response

seaona avatar Feb 07 '24 08:02 seaona

Hey team! Please add your planning poker estimate with Zenhub @blackdevelopa @jpuri @seaona @digiwand

digiwand avatar Feb 08 '24 15:02 digiwand

@SayaGT's designs are ready for dev -> https://www.figma.com/file/Q69vHaA7Or7Rxz4vdzjVHC/Support-for-tx-security-providers-(MVP)?type=design&node-id=7092%3A49741&mode=design&t=9EOsWjVlokhksbh6-1

holantonela avatar Feb 13 '24 11:02 holantonela