[Bug]: Ledger error messages are just showing `Unknown Error`

[plasmacorral]

Describe the bug

Based on the changes included in the 11.10 RC, and specifically https://github.com/MetaMask/metamask-extension/pull/21038 I was expecting to see more helpful error messaging for Ledger accounts. Unfortunately, the error messages presented in the RC seem less helpful than the before images in the PR mentioned, and do not currently match the after images in that PR.

Can confirm that the messages presented in the 11.10.0 RC are matching what is in v11.9.0. EDIT: this was found to be introduced in 11.7.0

Expected behavior

Given the user initiates the add hardware flow with the Ethereum app installed on Ledger When the Ledger device is unlocked And the Ethereum app is opened Then the webHID connection window is opened When the user locks the PSD according to the manual test steps in PR 21038 And then clicks continue on the webHID connection prompt Then an actionable error message should be presented to the user

Given the user initiates the add hardware flow with the Ethereum app installed on Ledger When the Ledger device is unlocked And the Ethereum app is NOT opened Then an actionable error message should be presented to the user

Screenshots/Recordings

Steps to reproduce

1. Setup MetaMask
2. Have Ledger unlocked with Ethereum app installed and opened
3. Attempt to add Ledger hardware
4. Before clicking on the webHID connection request lock Ledger device
5. After locking, click continue
6. Observe "Unknown error"

Other variation is to attempt to add Ledger without the Ethereum app opened

1. Setup MetaMask
2. Have Ledger unlocked with Ethereum app installed but NOT opened
3. Attempt to add Ledger hardware
4. Observe "Unknown error"

Was also producing a new error typically with the second attempt of the two scenarios above: "The iframe is not loaded yet"

Error messages or log output

No response

Version

11.9.0

Build type

None

Browser

Chrome

Operating system

MacOS

Hardware wallet

No response

Additional context

This was initially revealed in 11.10.0 RC testing, but the same errors can be triggered in v11.9.0

Severity

No response

[plasmacorral]

Traced this back and found that we had codes in the Ledger errors for 4c5e7bc5c233c1b3dfa616a518285382d8f231ed but they stop showing in 3713c18f691ccc7fb70fd472dade208e417987a7. The commit to develop cited was released within 11.7.0.

[github-actions[bot]]

This issue has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 45 days if there is no further activity. The MetaMask team intends on reviewing this issue before close, and removing the stale label if it is still a bug. We welcome new comments on this issue. We do not intend on closing issues if they report bugs that are still reproducible. Thank you for your contributions.

[github-actions[bot]]

This issue has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 45 days if there is no further activity. The MetaMask team intends on reviewing this issue before close, and removing the stale label if it is still a bug. We welcome new comments on this issue. We do not intend on closing issues if they report bugs that are still reproducible. Thank you for your contributions.