metamask-extension icon indicating copy to clipboard operation
metamask-extension copied to clipboard
verified publisher icon MetaMask

E2e request queuing

Open tmashuang opened this issue 1 year ago • 9 comments

Description

Adds e2e tests for the request queuing system. Tests include enable the toggle settings, sending a tx from a different selected/global network which results in a switch chain request, and request queuing for multiple daps on different networks.

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/1404

Manual testing steps

  1. yarn && yarn build:test
  2. yarn test:e2e:single test/e2e/tests/request-queuing/enable-queuing.spec.js --browser=chrome
  3. yarn test:e2e:single test/e2e/tests/request-queuing/switch-network.spec.js --browser=chrome
  4. yarn test:e2e:single test/e2e/tests/request-queuing/multiple-networks-dapps-txs.spec.js --browser=chrome
  5. All request queuing tests should pass individually. yarn test:e2e:chrome && yarn test:e2e:firefox for a bonus.

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • [x] I’ve followed MetaMask Coding Standards.
  • [x] I've clearly explained what problem this PR is solving and how it is solved.
  • [x] I've linked related issues
  • [x] I've included manual testing steps
  • [x] I've included screenshots/recordings if applicable
  • [x] I’ve included tests if applicable
  • [x] I’ve documented my code using JSDoc format if applicable
  • [x] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • [x] I’ve properly set the pull request status:
    • [ ] In case it's not yet "ready for review", I've set it to "draft".
    • [x] In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

tmashuang avatar Feb 05 '24 19:02 tmashuang

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] avatar Feb 05 '24 19:02 github-actions[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 68.51%. Comparing base (c9ccde4) to head (c599f14).

:exclamation: Current head c599f14 differs from pull request most recent head 698ab1e. Consider uploading reports for the commit 698ab1e to get more accurate results

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop   #22818      +/-   ##
===========================================
+ Coverage    68.49%   68.51%   +0.02%     
===========================================
  Files         1092     1088       -4     
  Lines        43170    42914     -256     
  Branches     11512    11426      -86     
===========================================
- Hits         29567    29399     -168     
+ Misses       13603    13515      -88

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 05 '24 22:02 codecov[bot]

Builds ready [2600e22]
Page Load Metrics (753 ± 15 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint87160106157
domContentLoaded9441773
load6958227533215
domInteractive9441773
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 86 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

metamaskbot avatar Feb 05 '24 22:02 metamaskbot

Builds ready [add1d9d]
Page Load Metrics (832 ± 31 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint92151118157
domContentLoaded10301963
load72810118326531
domInteractive10301963
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 86 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

metamaskbot avatar Feb 06 '24 06:02 metamaskbot

Builds ready [2f39f3f]
Page Load Metrics (779 ± 22 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint92156111167
domContentLoaded9211532
load7168887794522
domInteractive9211532
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 86 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

metamaskbot avatar Feb 06 '24 19:02 metamaskbot

Builds ready [195fb6a]
Page Load Metrics (778 ± 12 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint871169884
domContentLoaded10211631
load7368607782512
domInteractive10211631
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 86 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

metamaskbot avatar Feb 08 '24 23:02 metamaskbot

Builds ready [4f97800]
Page Load Metrics (722 ± 16 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint811178994
domContentLoaded9221631
load6877897223416
domInteractive9221631
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 86 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

metamaskbot avatar Feb 09 '24 18:02 metamaskbot

Builds ready [bbed57f]
Page Load Metrics (811 ± 23 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint82136105136
domContentLoaded9371984
load7238988114923
domInteractive9371984
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 86 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

metamaskbot avatar Feb 09 '24 19:02 metamaskbot

Builds ready [c599f14]
Page Load Metrics (1029 ± 43 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1323722084924
domContentLoaded973372512
load925129810298943
domInteractive973372512
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 86 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

metamaskbot avatar Feb 10 '24 02:02 metamaskbot

Builds ready [698ab1e]
Page Load Metrics (1911 ± 87 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1054801948239
domContentLoaded10101392713
load16322236191118287
domInteractive10101392713
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 86 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

metamaskbot avatar Feb 22 '24 23:02 metamaskbot