metamask-extension icon indicating copy to clipboard operation
metamask-extension copied to clipboard
verified publisher icon MetaMask

Revert remove staking link

Open martahj opened this issue 2 years ago • 6 comments

Description

Reverts the commits to remove the "Stake" button and associated announcement, ie the changes in this PR.

Manual testing steps

Confirm "Stake" button restored

Original PR: https://github.com/MetaMask/metamask-extension/pull/22347

  1. Go to Token Listing
  2. Verify that the new staking icon shows only for ETH mainnet
  3. Click on button; it should go to the MetaMask Porfolio stake page
  4. Verify that onClick, a new metametrics event is tracked

Confirm announcement restored

Original PR: https://github.com/MetaMask/metamask-extension/pull/22291

  1. Install MM build with this change
  2. The Stake announcement should appear, either last on the "What's New" list if you haven't seen previous announcements or as the only item in "What's New" if you have
  3. CTA should not click through to anything (just close the notification)

Screenshots/Recordings

Before

Screenshot 2024-02-05 at 11 00 17 AM

After

Screenshot 2024-02-05 at 10 56 29 AM Screenshot 2024-02-05 at 10 53 22 AM

Pre-merge author checklist

  • [X] I’ve followed MetaMask Coding Standards.
  • [X] I've clearly explained what problem this PR is solving and how it is solved.
  • [X] I've linked related issues
  • [X] I've included manual testing steps
  • [X] I've included screenshots/recordings if applicable
  • [X] I’ve included tests if applicable
  • [X] I’ve documented my code using JSDoc format if applicable
  • [x] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • [x] I’ve properly set the pull request status:
    • [x] In case it's not yet "ready for review", I've set it to "draft".
    • [ ] In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • [X] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • [X] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

martahj avatar Feb 05 '24 17:02 martahj

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] avatar Feb 05 '24 17:02 github-actions[bot]

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (14d1974) 68.55% compared to head (0937843) 68.55%.

Files Patch % Lines
.../components/app/whats-new-popup/whats-new-popup.js 0.00% 2 Missing :warning:
shared/notifications/index.js 80.00% 1 Missing :warning:
...ents/multichain/token-list-item/token-list-item.js 93.33% 1 Missing :warning:
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop   #22816      +/-   ##
===========================================
+ Coverage    68.55%   68.55%   +0.01%     
===========================================
  Files         1088     1088              
  Lines        42907    42932      +25     
  Branches     11415    11425      +10     
===========================================
+ Hits         29411    29431      +20     
- Misses       13496    13501       +5

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 05 '24 17:02 codecov[bot]

Builds ready [5c21704]
Page Load Metrics (810 ± 22 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint89145111168
domContentLoaded10401763
load7289108104522
domInteractive10401763
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 1.48 KiB (0.02%)
  • common: 1.11 KiB (0.02%)

metamaskbot avatar Feb 05 '24 21:02 metamaskbot

Builds ready [ae84b58]
Page Load Metrics (801 ± 22 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint801471122010
domContentLoaded105620126
load7239148014622
domInteractive105620126
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 1.48 KiB (0.02%)
  • common: 1.11 KiB (0.02%)

metamaskbot avatar Feb 07 '24 15:02 metamaskbot

Builds ready [acdb372]
Page Load Metrics (980 ± 20 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1082711903316
domContentLoaded1074352412
load91610579804120
domInteractive1074342412
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 1.48 KiB (0.02%)
  • common: 1.11 KiB (0.02%)

metamaskbot avatar Feb 13 '24 16:02 metamaskbot

Builds ready [0937843]
Page Load Metrics (1048 ± 46 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1252992064522
domContentLoaded1193392412
load799124510489646
domInteractive1193392412
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 1.48 KiB (0.02%)
  • common: 1.11 KiB (0.02%)

metamaskbot avatar Feb 13 '24 21:02 metamaskbot