metamask-extension
metamask-extension copied to clipboard
Add logic to cancel submit approvals buttons
Description
Implement cancel / Submit logic on personal sign page.
Related issues
Fixes: MetaMask/metamask-extension#22748
Manual testing steps
- Enable confirmation redesign locally
- Go to Test DAPP click personal sign button
- Cancel / Submit the page - it should work as expected
Screenshots/Recordings
https://github.com/MetaMask/metamask-extension/assets/2182307/0f846c05-4a1d-4056-b88d-3a1744f94f04
Pre-merge author checklist
- [X] I’ve followed MetaMask Coding Standards.
- [X] I've clearly explained what problem this PR is solving and how it is solved.
- [X] I've linked related issues
- [X] I've included manual testing steps
- [X] I've included screenshots/recordings if applicable
- [X] I’ve included tests if applicable
- [ ] I’ve documented my code using JSDoc format if applicable
- [X] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
- [X] I’ve properly set the pull request status:
- [ ] In case it's not yet "ready for review", I've set it to "draft".
- [X] In case it's "ready for review", I've changed it from "draft" to "non-draft".
Pre-merge reviewer checklist
- [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.
Builds ready [aa02ba9]
- builds: chrome, firefox
- builds (beta): chrome
- builds (flask): chrome, firefox
- builds (MMI): chrome, firefox
- builds (test): chrome, firefox
- builds (test-flask): chrome, firefox
- build viz: Build System
- mv3: Background Module Init Stats
- mv3: UI Init Stats
- mv3: Module Load Stats
- mv3: Bundle Size Stats
- mv2: E2e Actions Stats
- code coverage: Report
- storybook: Storybook
- typescript migration: Dashboard
- all artifacts
Page Load Metrics (801 ± 46 ms)
Platform | Page | Metric | Min (ms) | Max (ms) | Average (ms) | StandardDeviation (ms) | MarginOfError (ms) |
---|---|---|---|---|---|---|---|
Chrome | Home | firstPaint | 91 | 153 | 115 | 20 | 10 |
domContentLoaded | 9 | 61 | 21 | 13 | 6 | ||
load | 692 | 1010 | 801 | 96 | 46 | ||
domInteractive | 9 | 61 | 21 | 13 | 6 |
Bundle size diffs [🚨 Warning! Bundle size has increased!]
- background: 0 Bytes (0.00%)
- ui: 1.21 KiB (0.02%)
- common: 314 Bytes (0.01%)
Hey @eriknson : update on the UI feedbacks:
- Scroll down , account into modal are yet to be developer
- Current origin is
https://
thus its is not showinghttp
highlighted - Ethereum Symbol - I checked and we are using same svg icon as network select
- Footer - I fixed this
Codecov Report
Attention: Patch coverage is 72.72727%
with 3 lines
in your changes are missing coverage. Please review.
Project coverage is 68.73%. Comparing base (
ef0e1a8
) to head (3b5a0c7
).
Files | Patch % | Lines |
---|---|---|
...confirmations/components/confirm/footer/footer.tsx | 80.00% | 2 Missing :warning: |
ui/pages/confirmations/confirm/mock-data.ts | 0.00% | 1 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## develop #22809 +/- ##
========================================
Coverage 68.73% 68.73%
========================================
Files 1124 1125 +1
Lines 43617 43628 +11
Branches 11674 11676 +2
========================================
+ Hits 29976 29984 +8
- Misses 13641 13644 +3
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Builds ready [5d856f9]
- builds: chrome, firefox
- builds (beta): chrome
- builds (flask): chrome, firefox
- builds (MMI): chrome, firefox
- builds (test): chrome, firefox
- builds (test-flask): chrome, firefox
- build viz: Build System
- mv3: Background Module Init Stats
- mv3: UI Init Stats
- mv3: Module Load Stats
- mv3: Bundle Size Stats
- mv2: E2e Actions Stats
- code coverage: Report
- storybook: Storybook
- typescript migration: Dashboard
- all artifacts
Page Load Metrics (1061 ± 58 ms)
Platform | Page | Metric | Min (ms) | Max (ms) | Average (ms) | StandardDeviation (ms) | MarginOfError (ms) |
---|---|---|---|---|---|---|---|
Chrome | Home | firstPaint | 116 | 472 | 199 | 70 | 34 |
domContentLoaded | 10 | 123 | 44 | 36 | 17 | ||
load | 849 | 1284 | 1061 | 121 | 58 | ||
domInteractive | 10 | 123 | 44 | 36 | 17 |
Bundle size diffs [🚨 Warning! Bundle size has increased!]
- background: 0 Bytes (0.00%)
- ui: 1.21 KiB (0.02%)
- common: 314 Bytes (0.01%)
Builds ready [45b1e56]
- builds: chrome, firefox
- builds (beta): chrome
- builds (flask): chrome, firefox
- builds (MMI): chrome, firefox
- builds (test): chrome, firefox
- builds (test-flask): chrome, firefox
- build viz: Build System
- mv3: Background Module Init Stats
- mv3: UI Init Stats
- mv3: Module Load Stats
- mv3: Bundle Size Stats
- mv2: E2e Actions Stats
- code coverage: Report
- storybook: Storybook
- typescript migration: Dashboard
- all artifacts
Page Load Metrics (1957 ± 159 ms)
Platform | Page | Metric | Min (ms) | Max (ms) | Average (ms) | StandardDeviation (ms) | MarginOfError (ms) |
---|---|---|---|---|---|---|---|
Chrome | Home | firstPaint | 119 | 373 | 205 | 79 | 38 |
domContentLoaded | 12 | 99 | 40 | 24 | 11 | ||
load | 1717 | 3330 | 1957 | 331 | 159 | ||
domInteractive | 12 | 99 | 40 | 24 | 11 |
Bundle size diffs [🚨 Warning! Bundle size has increased!]
- background: 0 Bytes (0.00%)
- ui: 1.21 KiB (0.02%)
- common: 314 Bytes (0.01%)
@eriknson : This PR is adding logic to footer buttons not adding any UI element. Can you plz remove change request.
Builds ready [a68d936]
- builds: chrome, firefox
- builds (beta): chrome
- builds (flask): chrome, firefox
- builds (MMI): chrome, firefox
- builds (test): chrome, firefox
- builds (test-flask): chrome, firefox
- build viz: Build System
- mv3: Background Module Init Stats
- mv3: UI Init Stats
- mv3: Module Load Stats
- mv3: Bundle Size Stats
- mv2: E2e Actions Stats
- code coverage: Report
- storybook: Storybook
- typescript migration: Dashboard
- all artifacts
Page Load Metrics (1068 ± 382 ms)
Platform | Page | Metric | Min (ms) | Max (ms) | Average (ms) | StandardDeviation (ms) | MarginOfError (ms) |
---|---|---|---|---|---|---|---|
Chrome | Home | firstPaint | 75 | 181 | 126 | 27 | 13 |
domContentLoaded | 9 | 65 | 31 | 17 | 8 | ||
load | 69 | 1887 | 1068 | 796 | 382 | ||
domInteractive | 9 | 65 | 31 | 17 | 8 |
Bundle size diffs
- background: 0 Bytes (0.00%)
- ui: 0 Bytes (0.00%)
- common: 0 Bytes (0.00%)
Builds ready [a68d936]
- builds: chrome, firefox
- builds (beta): chrome
- builds (flask): chrome, firefox
- builds (MMI): chrome, firefox
- builds (test): chrome, firefox
- builds (test-flask): chrome, firefox
- build viz: Build System
- mv3: Background Module Init Stats
- mv3: UI Init Stats
- mv3: Module Load Stats
- mv3: Bundle Size Stats
- mv2: E2e Actions Stats
- code coverage: Report
- storybook: Storybook
- typescript migration: Dashboard
- all artifacts
Page Load Metrics (1068 ± 382 ms)
Platform | Page | Metric | Min (ms) | Max (ms) | Average (ms) | StandardDeviation (ms) | MarginOfError (ms) |
---|---|---|---|---|---|---|---|
Chrome | Home | firstPaint | 75 | 181 | 126 | 27 | 13 |
domContentLoaded | 9 | 65 | 31 | 17 | 8 | ||
load | 69 | 1887 | 1068 | 796 | 382 | ||
domInteractive | 9 | 65 | 31 | 17 | 8 |
Bundle size diffs
- background: 0 Bytes (0.00%)
- ui: 0 Bytes (0.00%)
- common: 0 Bytes (0.00%)
Builds ready [3b5a0c7]
- builds: chrome, firefox
- builds (beta): chrome
- builds (flask): chrome, firefox
- builds (MMI): chrome, firefox
- builds (test): chrome, firefox
- builds (test-flask): chrome, firefox
- build viz: Build System
- mv3: Background Module Init Stats
- mv3: UI Init Stats
- mv3: Module Load Stats
- mv3: Bundle Size Stats
- mv2: E2e Actions Stats
- code coverage: Report
- storybook: Storybook
- typescript migration: Dashboard
- all artifacts
Page Load Metrics (1370 ± 358 ms)
Platform | Page | Metric | Min (ms) | Max (ms) | Average (ms) | StandardDeviation (ms) | MarginOfError (ms) |
---|---|---|---|---|---|---|---|
Chrome | Home | firstPaint | 89 | 212 | 123 | 32 | 15 |
domContentLoaded | 19 | 81 | 33 | 19 | 9 | ||
load | 75 | 2092 | 1370 | 746 | 358 | ||
domInteractive | 19 | 81 | 33 | 19 | 9 |
Bundle size diffs
- background: 0 Bytes (0.00%)
- ui: 0 Bytes (0.00%)
- common: 0 Bytes (0.00%)