metamask-extension icon indicating copy to clipboard operation
metamask-extension copied to clipboard

Published 20 hours ago • verified publisher icon MetaMask

Add logic to cancel submit approvals buttons

Open jpuri opened this issue 6 months ago • 5 comments

Description

Implement cancel / Submit logic on personal sign page.

Related issues

Fixes: MetaMask/metamask-extension#22748

Manual testing steps

  1. Enable confirmation redesign locally
  2. Go to Test DAPP click personal sign button
  3. Cancel / Submit the page - it should work as expected

Screenshots/Recordings

https://github.com/MetaMask/metamask-extension/assets/2182307/0f846c05-4a1d-4056-b88d-3a1744f94f04

Pre-merge author checklist

  • [X] I’ve followed MetaMask Coding Standards.
  • [X] I've clearly explained what problem this PR is solving and how it is solved.
  • [X] I've linked related issues
  • [X] I've included manual testing steps
  • [X] I've included screenshots/recordings if applicable
  • [X] I’ve included tests if applicable
  • [ ] I’ve documented my code using JSDoc format if applicable
  • [X] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • [X] I’ve properly set the pull request status:
    • [ ] In case it's not yet "ready for review", I've set it to "draft".
    • [X] In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

jpuri avatar Feb 05 '24 11:02 jpuri

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] avatar Feb 05 '24 11:02 github-actions[bot]

Builds ready [aa02ba9]
Page Load Metrics (801 ± 46 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint911531152010
domContentLoaded96121136
load69210108019646
domInteractive96121136
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 1.21 KiB (0.02%)
  • common: 314 Bytes (0.01%)

metamaskbot avatar Feb 05 '24 13:02 metamaskbot

Hey @eriknson : update on the UI feedbacks:

  1. Scroll down , account into modal are yet to be developer
  2. Current origin is https:// thus its is not showing http highlighted
  3. Ethereum Symbol - I checked and we are using same svg icon as network select
  4. Footer - I fixed this

Screenshot 2024-02-13 at 5 12 27 PM

jpuri avatar Feb 13 '24 11:02 jpuri

Codecov Report

Attention: Patch coverage is 72.72727% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 68.73%. Comparing base (ef0e1a8) to head (3b5a0c7).

Files Patch % Lines
...confirmations/components/confirm/footer/footer.tsx 80.00% 2 Missing :warning:
ui/pages/confirmations/confirm/mock-data.ts 0.00% 1 Missing :warning:
Additional details and impacted files 
@@           Coverage Diff            @@
##           develop   #22809   +/-   ##
========================================
  Coverage    68.73%   68.73%           
========================================
  Files         1124     1125    +1     
  Lines        43617    43628   +11     
  Branches     11674    11676    +2     
========================================
+ Hits         29976    29984    +8     
- Misses       13641    13644    +3

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 14 '24 10:02 codecov[bot]

Builds ready [5d856f9]
Page Load Metrics (1061 ± 58 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1164721997034
domContentLoaded10123443617
load8491284106112158
domInteractive10123443617
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 1.21 KiB (0.02%)
  • common: 314 Bytes (0.01%)

metamaskbot avatar Feb 14 '24 11:02 metamaskbot

Builds ready [45b1e56]
Page Load Metrics (1957 ± 159 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1193732057938
domContentLoaded1299402411
load171733301957331159
domInteractive1299402411
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 1.21 KiB (0.02%)
  • common: 314 Bytes (0.01%)

metamaskbot avatar Feb 22 '24 10:02 metamaskbot

@eriknson : This PR is adding logic to footer buttons not adding any UI element. Can you plz remove change request.

jpuri avatar Mar 04 '24 08:03 jpuri

Builds ready [a68d936]
Page Load Metrics (1068 ± 382 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint751811262713
domContentLoaded96531178
load6918871068796382
domInteractive96531178
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

metamaskbot avatar Mar 13 '24 06:03 metamaskbot

Builds ready [a68d936]
Page Load Metrics (1068 ± 382 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint751811262713
domContentLoaded96531178
load6918871068796382
domInteractive96531178
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

metamaskbot avatar Mar 13 '24 06:03 metamaskbot

Builds ready [3b5a0c7]
Page Load Metrics (1370 ± 358 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint892121233215
domContentLoaded198133199
load7520921370746358
domInteractive198133199
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

metamaskbot avatar Mar 13 '24 06:03 metamaskbot